Skip to content

Chore: Fetch workflowstepdefinitions CRD from KubeVela repository#221

Merged
briankane merged 1 commit intokubevela:mainfrom
vaibhav0096:chore/fetch-workflowstepdefinition-crd-from-kubevela-repo
Nov 25, 2025
Merged

Chore: Fetch workflowstepdefinitions CRD from KubeVela repository#221
briankane merged 1 commit intokubevela:mainfrom
vaibhav0096:chore/fetch-workflowstepdefinition-crd-from-kubevela-repo

Conversation

@vaibhav0096
Copy link
Copy Markdown
Contributor

@vaibhav0096 vaibhav0096 commented Nov 24, 2025

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Summary by cubic

Fetch workflowstepdefinitions CRD directly from the KubeVela repo during sync-crds to prevent drift, with version control via KUBEVELA_VERSION. Also synced the chart CRD to match upstream.

  • Refactors
    • Added KUBEVELA_VERSION (default: master) and KUBEVELA_RAW_URL in const.mk.
    • Updated sync-crds to download core.oam.dev_workflowstepdefinitions.yaml from kubevela/charts/vela-core/crds via GitHub raw.
    • Aligned charts/vela-workflow CRD with upstream (newline at EOF).

Written for commit 5dfea1b. Summary will update automatically on new commits.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.19%. Comparing base (d7db9c4) to head (462eb23).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   62.49%   70.19%   +7.70%     
==========================================
  Files          62       62              
  Lines        4415     5009     +594     
==========================================
+ Hits         2759     3516     +757     
+ Misses       1324     1142     -182     
- Partials      332      351      +19     
Flag Coverage Δ
e2etests 21.39% <ø> (?)
unit-test 64.22% <ø> (+1.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: vaibhav0096 <vaibhav.agrawal0096@gmail.com>
@vaibhav0096 vaibhav0096 force-pushed the chore/fetch-workflowstepdefinition-crd-from-kubevela-repo branch from 462eb23 to 5dfea1b Compare November 24, 2025 08:03
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@briankane briankane merged commit 924e73a into kubevela:main Nov 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants