Skip to content

VEP 100: Introduce metaData and MetaDataSecretRef feild for adding custom medata to cloud-init #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

VEP 100: Introduce metaData and MetaDataSecretRef feild for adding custom medata to cloud-init #101

wants to merge 1 commit into from

Conversation

@olamilekan000
Copy link

@olamilekan000 olamilekan000 commented Oct 19, 2025

VEP Metadata

Tracking issue: #100
SIG label: /sig compute

What this PR does

metaData and MetaDataSecretRef where added to CloudInitNoCloudSource inorder
to support the addition of custom metadata to cloud-init.

Special notes for your reviewer

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Oct 19, 2025
@kubevirt-bot
Copy link

kubevirt-bot commented Oct 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xpivarc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olamilekan000 olamilekan000 mentioned this pull request Oct 19, 2025
Closed
8 tasks
@olamilekan000 olamilekan000 changed the title VEP 100: Introduce metaData and MetaDataSecretRef feild for adding custom medata to the cloud-init VEP 100: Introduce metaData and MetaDataSecretRef feild for adding custom medata to cloud-init Oct 19, 2025
@olamilekan000 olamilekan000 force-pushed the inroduce-metadata-field-to-cloudinit branch from 10e0b3d to 7cf1266 Compare October 20, 2025 06:14
0xFelix
0xFelix reviewed Oct 20, 2025
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, thanks for drafting this VEP so quickly.

Can you please add a target version to Alpha/Beta? We're past the 1.7 VEP freeze, so this would need to go into 1.8.

How would full IRSA support look like?

@vladikr I think we can do without FeatureGate for this one?

@olamilekan000 olamilekan000 force-pushed the inroduce-metadata-field-to-cloudinit branch from 7cf1266 to 4a8ec35 Compare October 20, 2025 11:34
@olamilekan000
VEP 100: Introduce metaData and MetaDataSecretRef feild for adding cu…
9f093fb 
…stom medata to the cloud-init

Signed-off-by: olalekan odukoya <[email protected]>
@olamilekan000 olamilekan000 force-pushed the inroduce-metadata-field-to-cloudinit branch from 4a8ec35 to 9f093fb Compare October 20, 2025 11:38
@EdDev
Copy link
Member

EdDev commented Oct 22, 2025

@vladikr I think we can do without FeatureGate for this one?

+1

@olamilekan000 olamilekan000 requested a review from 0xFelix October 25, 2025 05:12
0xFelix
0xFelix approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good to me.

Can you elaborate on what is missing for full ISRA support?

Ping @vladikr

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyarwood lyarwood Awaiting requested review from lyarwood

@vladikr vladikr Awaiting requested review from vladikr

@xpivarc xpivarc Awaiting requested review from xpivarc

1 more reviewer

@0xFelix 0xFelix 0xFelix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@0xFelix 0xFelix

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olamilekan000 @kubevirt-bot @EdDev @0xFelix