VEP 111: Upgrade Path for VMs Using Ordinal Naming for Secondary Networks #112
Conversation
kubevirt-bot
added
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
orelmisan
force-pushed
the
ordinal-naming-scheme-upgrade-path
branch
from
d449365 to
f9f5902
Compare
Signed-off-by: Orel Misan <[email protected]>
orelmisan
force-pushed
the
ordinal-naming-scheme-upgrade-path
branch
from
f9f5902 to
5bcdf9a
Compare
|
/cc @Barakmor1 |
|
@Barakmor1's kubevirt/kubevirt#16212 is a POC of the mechanism proposed here. |
| 1. The target virt-launcher process starts, creates a Unix domain socket, and begins listening for incoming connections. | ||
| 2. As part of the migration, libvirt executes the hook script on the target pod, passing the original domain XML to the | ||
| script's stdin. | ||
| 3. The hook script connects to the virt-launcher's Unix socket and passes the domain XML from its stdin to the socket. | ||
| 4. The virt-launcher server receives the XML, parses it, scans for legacy configurations (like ordinal interface names), | ||
| and performs the necessary mutations. | ||
| 5. virt-launcher sends the mutated domain XML back to the hook script over the same socket connection. | ||
| 6. The hook script reads the mutated XML from the socket and writes it to its stdout. | ||
| 7. Libvirt reads the stdout from the hook script and uses this final, modified XML to define the VM on the target. |
There was a problem hiding this comment.
@orelmisan Thanks for keeping me involved in this work.
This PR is inspired by the plan we discussed.
Additional details are described in the PR description.
|
/cc |
|
As discussed on yesterday's SIG compute call, this VEP will depend on #141. |
kubevirt-bot
added
the
do-not-merge/work-in-progress
4 participants
VEP Metadata
Tracking issue:
SIG label:
/sig network
/sig compute
What this PR does
Special notes for your reviewer