- 
                Notifications
    You must be signed in to change notification settings 
- Fork 162
Avoid setting a default value for completionTimeoutPerGiB #3164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Avoid setting a default value for completionTimeoutPerGiB #3164
Conversation
Signed-off-by: Itamar Holder <[email protected]>
Signed-off-by: Itamar Holder <[email protected]>
Signed-off-by: Itamar Holder <[email protected]>
| [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. 
Needs approval from an approver in each of these files:
 Approvers can indicate their approval by writing  | 
Signed-off-by: Itamar Holder <[email protected]>
95a1dea    to
    7b349e7      
    Compare
  
    | 
 | 
| Please notice that is going to work only for new installations but it's not going to work for upgrades. I'm even not sure that keeping it undefined is the best way to handle it. | 
| @iholder101: The following tests failed, say  
 Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. | 
| hco-e2e-kv-smoke-gcp lane succeeded. | 
| @hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this: 
 Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. | 
| PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. | 
| Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with  /lifecycle stale | 
| Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with  /lifecycle rotten | 
| /remove-lifecycle rotten | 
| Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with  /lifecycle stale | 
| @iholder101: The following tests failed, say  
 Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. | 



What this PR does / why we need it:
This PR serves two purposes:
Release note: