-
Notifications
You must be signed in to change notification settings - Fork 162
Adds the --dump-network-policies flag to the AAQ CSV generator #3690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
, as introduced in kubevirt/application-aware-quota#159. This flag enables including NetworkPolicies in the generated CSV to improve overall security. The policies ensure that AAQ pods can only connect to the API server and DNS, and only receive incoming connections for the webhook and metrics servers. Signed-off-by: bmordeha <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Barakmor1 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Thanks for this PR @Barakmor1 ! We are not implementing network policies for the community release, yet. We'll do it later. /hold |
|
@Barakmor1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@Barakmor1 - in addition to the comment above, we'll need also an AAQ release, as the current AAQ operator ppod does not support the new flag. |
|
@Barakmor1 - please fix the PR title to reflect that it's related to AAQ. |
Done
Yes make sense |



Adds the --dump-network-policies flag to the AAQ CSV generator, as introduced in
kubevirt/application-aware-quota#159. This flag enables including NetworkPolicies in the generated CSV to improve overall security.
The policies ensure that AAQ pods can only connect to the API server and DNS, and only receive incoming connections for the webhook and metrics servers.
What this PR does / why we need it:
Reviewer Checklist
Jira Ticket:
Release note: