Conversation
ikonkere
commented
Aug 29, 2019
- SE server implementation with Weld SE CDI support;
- updated BOM.
* SE server implementation with Weld SE CDI support; * updated BOM.
|
Thank you. We will have a look and let you know soon. |
urbim
left a comment
There was a problem hiding this comment.
Thanks for this contribution! I added some comments (mostly style).
It would be great if you could also create a simple sample application (as a PR to https://github.com/kumuluz/kumuluzee-samples) showcasing a simple injection and perhaps injection of some configuration properties from our configuration framework.
Thanks again!
|
Created a PR with a sample: kumuluz/kumuluzee-samples#25 |
* Factored out all components unrelated to Weld from cdi-weld to new project cdi-common; * Created new project cdi-weld-se that incapsulates Weld SE support; * Updated server-se with these changes; * Updated parent and BOM pom.xml with new projects.
* Merged kumuluz-se-server to kumuluzee-cdi-weld-se and removed the former. * Removed corresponding projects from parent and BOM pom.xml
|
Any progress on this? |
|
@ikonkere can you rebase to current? I was testing this a bit and it makes sense as a weld-se wrapper. Unfortunately the extension ecosystem support is very rough. I managed to load the config extension, that was about it.
It looks like we have some more work to do for enablement in extensions which are not web specific when this is merged. |
|
Well, obviously there's no servlet support under SE, so it doesn't make sense trying to start anything that depends on I'm surprised I will definitely have a look as soon as i'm out of isolation: unfortunately i have no useful working environment or remote access available right now. |
|
I think the rest-client failure is mainly due to no distinction between jax-rs client and server side dependencies in our packaged components. log4j2 I am not sure why, I think just an overreaching check in the extension code. I do not think it is necessary to have extensions ready before the merge, but it is something to keep in mind. Without this compatibility, the SE server has limited usage with not much else benefit compared to just using stock weld-se. |