Change Icon block category to media (#3)#15
Closed
fumikito wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Closes #3
Icon ブロックのカテゴリを
commonからmediaに変更します。背景
commonカテゴリは WordPress 5.5(Gutenberg #19279)でブロックカテゴリが再編された際に廃止され、commonのブロックは現在textに表示されてしまいます。Icon ブロックの性質上、textよりmediaが適切です。変更内容
assets/js/icon-block.js(ソース):category: 'common'→'media'dist/js/icon-block.js(ビルド済み配布物):category:"common"→category:"media"補足
ビルドツールチェーンの近代化(#12)が未完のため gulp ビルドは回さず、配布物の該当トークン(一意)のみを同一内容で手修正しています。差分は文字列リテラル1箇所のみで、挙動への影響はカテゴリ表示位置の変更だけです。