Skip to content

[DB-1677] Draft: Reinstate DisableExternalTcpTls option #5275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[DB-1677] Draft: Reinstate DisableExternalTcpTls option #5275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/KurrentDB.Core/ClusterVNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,9 @@ public ClusterVNode(ClusterVNodeOptions options,
OptionsFormatter.LogConfig("Archive", archiveOptions);
archiveOptions.Validate();

var disableInternalTcpTls = options.Application.Insecure;
var disableExternalTcpTls = options.Application.Insecure;
var nodeTcpOptions = GetOptions<NodeTcpOptions>("TcpPlugin");
var disableInternalTcpTls = options.Application.Insecure;
var disableExternalTcpTls = options.Application.Insecure || nodeTcpOptions.DisableExternalTcpTls;
var enableExternalTcp = nodeTcpOptions.EnableExternalTcp;

var httpEndPoint = new IPEndPoint(options.Interface.NodeIp, options.Interface.NodePort);
Expand Down
1 change: 1 addition & 0 deletions src/KurrentDB.Core/NodeTcpOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ namespace KurrentDB.Core;
public class NodeTcpOptions {
public int NodeTcpPort { get; init; } = 1113;
public bool EnableExternalTcp { get; init; }
public bool DisableExternalTcpTls { get; init; }
public int? NodeTcpPortAdvertiseAs { get; init; }
}
Loading