feat(tests): add 29 model tests for forward pass, LTI stability, generation, RMSNorm, causal mask, LoRA and loop-index embedding#22
Open
miheer-smk wants to merge 3 commits intokyegomez:mainfrom
Open
Conversation
…ration, RMSNorm, causal mask, LoRA, and loop-index embedding
Borda
reviewed
Apr 22, 2026
Borda
left a comment
There was a problem hiding this comment.
I believe you shall add minimal CI to run these and so prove they are correct... 🐰
Author
|
@Borda — done! Added .github/workflows/tests.yml which runs all 29 tests on Python 3.10 and 3.11 via GitHub Actions CI. Both passed successfully... |
Author
|
@Borda @kyegomez — here's the CI proof. Both Python 3.10 and 3.11 pass all 29 tests on a clean machine: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR adds
Adds
tests/test_model.py— 29 tests covering the core OpenMythos model.The existing test suite only covered RoPE and the tokenizer.
This PR fills the gap by testing the model itself.
Tests added (9 categories)
Related to #5