fix: normalize torch version to >=2.1.0 across all dependency files#37
Open
spoturno wants to merge 1 commit intokyegomez:mainfrom
Open
fix: normalize torch version to >=2.1.0 across all dependency files#37spoturno wants to merge 1 commit intokyegomez:mainfrom
spoturno wants to merge 1 commit intokyegomez:mainfrom
Conversation
pyproject.toml pinned torch==2.11.0 (an invalid version), requirements.txt used >=2.1.0, and training/requirements.txt used >=2.11.0. Aligned all three to >=2.1.0 for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The torch version requirement is inconsistent across the three dependency files:
pyproject.tomltorch = "2.11.0"(exact pin to a non-existent version)requirements.txttorch>=2.1.0training/requirements.txttorch>=2.11.0(also non-existent)torch 2.11.0does not exist on PyPI — the latest 2.x releases follow2.1.x,2.2.x,2.3.x, etc. This causes install failures for anyone usingpyproject.tomlor the training requirements.Fix
Aligned all three files to
torch>=2.1.0, matching the existingrequirements.txtconvention.