fix(tests): slice freqs_cis to sequence length in unit tests#42
Closed
sjswerdloff wants to merge 2 commits intokyegomez:mainfrom
Closed
fix(tests): slice freqs_cis to sequence length in unit tests#42sjswerdloff wants to merge 2 commits intokyegomez:mainfrom
sjswerdloff wants to merge 2 commits intokyegomez:mainfrom
Conversation
Tests that call GQAttention, MLAttention, TransformerBlock, and RecurrentBlock directly were passing full-length freqs_cis (max_seq_len) instead of slicing to the actual sequence length T. This caused a tensor size mismatch in apply_rope when the RoPE frequencies didn't match the input sequence dimension. The model's forward() method slices correctly — only the unit tests that call components directly were affected. Fixes 13 test failures: - TestGQAttention: 3 tests - TestMLAttention: 4 tests - TestTransformerBlock: 3 tests - TestRecurrentBlock: 3 tests
The ZOH discretization exp(-exp(clamp(x, -20, 20))) reaches exactly 1.0 in float32 at the clamp boundary. This is the neutral point (no decay), not divergence — the stability guarantee is A ∈ (0, 1]. The test with lr=1e3 intentionally pushes parameters to extremes and was intermittently failing with assert 1.0 < 1.0.
Author
|
PR #41 has a more comprehensive approach . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GQAttention,MLAttention,TransformerBlock, andRecurrentBlockdirectly were passing full-lengthfreqs_cis(shape(max_seq_len, dim//2)) instead of slicing to the actual sequence lengthTRuntimeError: The size of tensor a (T) must match the size of tensor b (max_seq_len)inapply_ropeforward()method slices correctly — only the unit tests were affectedChanges
self.freqs[:T]in all 13 affected test call sitesTest plan
python -m pytest test_main.py -q— 66 passed, 1 flaky (test_spectral_radius_stable_after_large_grad_step— float32 boundary, pre-existing)🤖 Generated with Claude Code
Co-Authored-By: clement-7074f29f clement-7074f29f@sjstargetedsolutions.co.nz