Revert "Remove cargo from regressions test" - #214
Open
l2dy wants to merge 2 commits into
Open
Conversation
This reverts commit 0f0b78c.
When a feature dependency like `depname/feature` references an optional dependency that uses `dep:` syntax (no implicit feature created), the feature graph builder incorrectly created a phantom PackageFeature node for the dependency name. This caused IllegalStateException in FeatureGraph.buildFor when the node didn't exist in the graph. Only create the implicit dependency feature when it actually exists in the package's rawFeatures map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0f0b78c.