driver/power: Add sentry_sequential backend for single-bank models#1789
Open
ohporter wants to merge 1 commit intolabgrid-project:masterfrom
Open
driver/power: Add sentry_sequential backend for single-bank models#1789ohporter wants to merge 1 commit intolabgrid-project:masterfrom
ohporter wants to merge 1 commit intolabgrid-project:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1789 +/- ##
========================================
+ Coverage 45.2% 45.3% +0.1%
========================================
Files 174 175 +1
Lines 13752 13781 +29
========================================
+ Hits 6224 6253 +29
Misses 7528 7528
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ohporter
force-pushed
the
sentry
branch
2 times, most recently
from
c52abcc to
97ec4a9
Compare
Add a new power backend for Sentry PDUs that use sequential OID mapping (1.1.1 through 1.1.16) instead of the multi-bank mapping used by the existing sentry backend. This is suitable for single-bank models like the CW-16V1. The original sentry backend remains unchanged for multi-bank models like CW-24VDD and 4805-XLS-16. Includes unit tests with 100% coverage for the new backend. Signed-off-by: Matt Porter <mporter@konsulko.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new power driver for Sentry PDUs that use sequential OID mapping. This supports single-bank models like CW-16V1 which number ports sequentially (1.1.1 through 1.1.16) rather than using the multi-bank scheme (6 banks of 8 outlets) used by models like CW-24VDD.
Documentation now describes both backends and explains when to use each one.
Verified on a Sentry CDU CW-16V1.
Checklist