drivers: Add eth008 digital output#1821
Open
Fomys wants to merge 1 commit intolabgrid-project:masterfrom
Open
Conversation
Eth008 is technically not a power supply controler, it is a simple relay board. To allow using it as a digital output, implement the proper digital output driver and resource. In addition, the HTTP implementation of eth008 power driver seems broken with older revision of board. The driver expect a reply like `<text> 0000000`, but with my board (older revision) the reply is only `<text> 0`. the io.cgi?relay is also not documented in both older and newer revision. I switched to the TCP API, tested with my own board. According to documentation the protocol is the same on the two eth008 revision. Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
Author
|
I just force-pushed to fix the ruff issue, but the change don't appear here. What should I do? |
Member
|
You shouldn't (need to) fix unrelated ruff issues in this PR. We'll take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eth008 is technically not a power supply controler, it is a simple relay board. To allow using it as a digital output, implement the proper digital output driver and resource.
This PR implement:
I did not remove the existing HTTP implementation for power driver to avoid breaking existing configuration, but I think it could be replaced by a DigitalOutputPowerDriver + Eth008DigitalOutputDriver
Description
Checklist