driver/power/poe_netgear_plus: Add support#1822
Open
AiyionPrime wants to merge 2 commits intolabgrid-project:masterfrom
Open
driver/power/poe_netgear_plus: Add support#1822AiyionPrime wants to merge 2 commits intolabgrid-project:masterfrom
AiyionPrime wants to merge 2 commits intolabgrid-project:masterfrom
Conversation
e65e52c to
130a416
Compare
Author
|
@jluebbe @Bastian-Krause could one of you enable the CI for me? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1822 +/- ##
========================================
- Coverage 45.2% 45.1% -0.1%
========================================
Files 174 175 +1
Lines 13752 13791 +39
========================================
+ Hits 6224 6230 +6
- Misses 7528 7561 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for NETGEAR Plus devices Signed-off-by: Burfeind, Jan-Niklas <jan-niklas.burfeind@sennheiser.com>
130a416 to
2cdb063
Compare
Author
|
Coverage should now be at 27.5%. I'm torn whether it would be worthwhile to mock the remaining lines, which require hardware. Please let me know if you'd like to see 100%, while its not testing real hardware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds power driver support via PoE for NETGEAR Plus devices.
Those are pretty cheap managed consumer switches with no SNMP support.
I verified it by copying
examples/power/*and modified theenv.ymllike this:And ran the test.
The hardware I used to test this is a
GS308EP, but every device listed at py_netgear_plus1 should work.Checklist
Documentation for the feature
Tests for the feature
The arguments and description in doc/configuration.rst have been updated
Add a section on how to use the feature to doc/usage.rstno new driver feature addedAdd a section on how to use the feature to doc/development.rstno new library feature addedPR has been tested
Man pages have been regeneratedman pages haven't been touchedFootnotes
https://github.com/foxey/py-netgear-plus?tab=readme-ov-file#supported-and-tested-netgear-modelsproducts-and-firmware-versions ↩