Skip to content

Comments

run ruff format on some files#1823

Open
jluebbe wants to merge 1 commit intolabgrid-project:masterfrom
jluebbe:coding-style
Open

run ruff format on some files#1823
jluebbe wants to merge 1 commit intolabgrid-project:masterfrom
jluebbe:coding-style

Conversation

@jluebbe
Copy link
Member

@jluebbe jluebbe commented Feb 20, 2026

This is the result of running ruff format on all files currently not touched by any open PR.

This is the result of running ruff format on all files currently not
touched by any open PR.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
@jluebbe jluebbe requested a review from Emantor February 20, 2026 16:54
@jluebbe jluebbe requested a review from krevsbech as a code owner February 20, 2026 16:54
@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 47.30392% with 215 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.2%. Comparing base (81d768e) to head (fc77c7f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/autoinstall/main.py 0.0% 23 Missing ⚠️
labgrid/driver/usbtmc/keysight_dsox2000.py 0.0% 18 Missing ⚠️
labgrid/driver/usbaudiodriver.py 0.0% 16 Missing ⚠️
labgrid/driver/usbtmcdriver.py 11.7% 15 Missing ⚠️
labgrid/driver/usbtmc/tektronix_tds2000.py 0.0% 13 Missing ⚠️
labgrid/driver/power/digitalloggers_restapi.py 0.0% 11 Missing ⚠️
labgrid/util/agents/udisks2.py 0.0% 10 Missing ⚠️
labgrid/driver/lxausbmuxdriver.py 11.1% 8 Missing ⚠️
labgrid/util/agents/deditec_relais8.py 20.0% 8 Missing ⚠️
labgrid/driver/flashromdriver.py 40.0% 6 Missing ⚠️
... and 35 more
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1823   +/-   ##
======================================
  Coverage    45.2%   45.2%           
======================================
  Files         174     174           
  Lines       13752   13752           
======================================
  Hits         6224    6224           
  Misses       7528    7528           
Flag Coverage Δ
3.10 45.2% <47.3%> (ø)
3.11 45.2% <47.3%> (ø)
3.12 45.2% <47.3%> (ø)
3.13 45.2% <47.3%> (ø)
3.14 45.2% <47.3%> (ø)
3.9 45.3% <47.3%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarekSzczypinski
Copy link
Contributor

I think that additionally those files/directories should be added to pyproject.toml to include under [tool.ruff].

@jluebbe
Copy link
Member Author

jluebbe commented Feb 23, 2026

I thought about that, too. Having almost half of our python files in the list seemed excessive. I'd prefer to add whole directories when they are clean. Nevertheless, merging this now (and doing similar PRs in the future) should get us much closer to being "ruff clean" with little distuption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants