-
Notifications
You must be signed in to change notification settings - Fork 0
Implement required field asterisk indicator #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
🔍 Check Suite Status for PR #124
Results & Findingsbuild: ✅ I've fixed the failing checks in PR #124 by updating the test workflow. |
… props to fix TypeScript errors
📝 Storybook Preview: View Storybook This preview will be updated automatically when you push new changes to this PR.
|
…ding Storybook before tests
Overview
This PR implements a required field asterisk indicator for form fields in the @lambdacurry/forms library. This feature enhances form usability by clearly indicating which fields are required.
Implementation
FormLabel
component to:Technical Details
This approach works by:
showRequiredIndicator
prop to control the behaviorTesting
To test this implementation:
yarn storybook
Related Issues
Addresses subissue 360T-603: Implement required field asterisk indicator
Part of parent issue 360T-602: Explore adding autofill management to form library
💻 View my work • 👤 Initiated by
Jake Ruesink
• About Codegen⛔ Remove Codegen from PR • 🚫 Ban action checks