Skip to content

Conversation

codegen-sh[bot]
Copy link
Contributor

@codegen-sh codegen-sh bot commented Aug 9, 2025

Requested by: Jake Ruesink

Summary

  • Revert the production seed change in Todo initial state: set the second seed back to completed: true.
  • Update tests to no longer depend on production seed values by:
    • Mocking storage in todo-context tests for controlled initial state
    • Asserting state transitions without relying on specific seed-computed text
    • Adding a hydration test that seeds storage explicitly
  • Fix AddTodo tests by mocking remix-hook-form and @lambdacurry/forms to remove Router coupling while preserving behavior expectations (trimming, empty guard, and reset semantics).

Why
Production seed should remain stable for users; tests should control their own initial state rather than altering production data. AddTodo component relies on remix-hook-form which expects a Router context; unit tests should avoid full routing setup.

Details

  • apps/todo-app/app/lib/todo-context.tsx: Restore completed: true for the second initial todo.
  • apps/todo-app/app/lib/tests/todo-context.test.tsx:
    • Mock in-memory storage
    • Loosen seed-coupled assertions and add storage-hydration test
    • Ensure clear-completed test counts deterministically
  • apps/todo-app/app/components/tests/add-todo.test.tsx:
    • Mock remix-hook-form to emulate handleSubmit, trim, and reset semantics
    • Mock @lambdacurry/forms TextField to a plain input and keep FormError inert

Acceptance

  • All tests pass locally via bun run test:ci.
  • No production seed dependence in tests.

Compliance

  • Follows repo rules: fetched latest, used feature branch, included co-author in commit. Did not include Linear IDs in commit message.

Files modified

  • apps/todo-app/app/lib/todo-context.tsx
  • apps/todo-app/app/lib/tests/todo-context.test.tsx
  • apps/todo-app/app/components/tests/add-todo.test.tsx

💻 View my work • 👤 Initiated by Jake RuesinkAbout Codegen
⛔ Remove Codegen from PR🚫 Ban action checks

…dent of production seed by mocking storage and decoupling from seed values; fix AddTodo tests with minimal mocks for remix-hook-form

Co-authored-by: Jake Ruesink <[email protected]>
Copy link

linear bot commented Aug 9, 2025

STA-8 [Correctness] Revert seed change and fix tests to not depend on production seed

Requested by: Jake Ruesink

Summary
Revert the production seed change made for test convenience and adjust tests to control initial state explicitly. Production data should remain stable and not be tuned for tests.

Base branch for PR: codegen-bot/persist-todos-localstorage-STA-2-1754688724
Target repo: lambda-curry/react-router-starter

Code context

  • File: apps/todo-app/app/lib/todo-context.tsx
  • Current change:
// Ensure tests that expect a single completed item after one toggle pass
completed: false,
  • Revert to:
completed: true,

Test strategy

  • Update tests to avoid relying on production seed values:
    • Provide a controlled initial state by mocking storage or by a test-only wrapper that injects initial state.
    • Ensure toggle/clear-completed tests set up state deterministically.

Acceptance criteria

  • initialState second seed restored to completed: true.
  • All tests pass by controlling initial state without depending on production seed.

References

Copy link

coderabbitai bot commented Aug 9, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codegen/sta-8-correctness-revert-seed-change-and-fix-tests-to-not-depend

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jaruesink
Copy link
Contributor

jaruesink commented Aug 9, 2025

@codegen-sh resolve the conflicts carefully in a way that the tests will pass and push up the changes

I'll carefully resolve the conflicts and ensure tests pass before pushing the changes! 🛠️

💻 View my work🛑 Stop

Copy link
Contributor Author

codegen-sh bot commented Aug 9, 2025

@jaruesink (Jake Ruesink) — conflicts resolved and updates pushed to the same branch. All tests pass locally with bun run test:ci.

🔄 View Updated PR #13 on Github: #13

  • Reverted the seed (second todo back to completed: true).
  • Decoupled tests from production seed by mocking storage and loosening seed-coupled assertions; added a hydration test.
  • Stabilized AddTodo tests by mocking remix-hook-form and @lambdacurry/forms to avoid Router coupling while preserving trim/empty/reset behavior.

If you’d prefer the AddTodo tests use a MemoryRouter instead of the lightweight mocks, I can switch to that. Otherwise this is good to merge pending CI.

Requested by: Jake Ruesink

💻 View my work🛑 Stop • React 👍 or 👎

@jaruesink jaruesink marked this pull request as ready for review August 9, 2025 03:53
@jaruesink jaruesink merged commit db102d2 into codegen-bot/persist-todos-localstorage-STA-2-1754688724 Aug 9, 2025
2 checks passed
@jaruesink jaruesink deleted the codegen/sta-8-correctness-revert-seed-change-and-fix-tests-to-not-depend branch August 9, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant