-
Notifications
You must be signed in to change notification settings - Fork 0
Revert seed change; decouple tests from production seed; stabilize AddTodo tests #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dent of production seed by mocking storage and decoupling from seed values; fix AddTodo tests with minimal mocks for remix-hook-form Co-authored-by: Jake Ruesink <[email protected]>
STA-8 [Correctness] Revert seed change and fix tests to not depend on production seed
Requested by: Jake Ruesink Summary Base branch for PR: codegen-bot/persist-todos-localstorage-STA-2-1754688724 Code context
// Ensure tests that expect a single completed item after one toggle pass
completed: false,
completed: true, Test strategy
Acceptance criteria
References |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@codegen-sh resolve the conflicts carefully in a way that the tests will pass and push up the changes
|
…een) Co-authored-by: Jake Ruesink <[email protected]>
@jaruesink (Jake Ruesink) — conflicts resolved and updates pushed to the same branch. All tests pass locally with 🔄 View Updated PR #13 on Github: #13
If you’d prefer the AddTodo tests use a MemoryRouter instead of the lightweight mocks, I can switch to that. Otherwise this is good to merge pending CI. Requested by: Jake Ruesink 💻 View my work • 🛑 Stop • React 👍 or 👎 |
db102d2
into
codegen-bot/persist-todos-localstorage-STA-2-1754688724
Requested by: Jake Ruesink
Summary
completed: true
.remix-hook-form
and@lambdacurry/forms
to remove Router coupling while preserving behavior expectations (trimming, empty guard, and reset semantics).Why
Production seed should remain stable for users; tests should control their own initial state rather than altering production data. AddTodo component relies on remix-hook-form which expects a Router context; unit tests should avoid full routing setup.
Details
completed: true
for the second initial todo.remix-hook-form
to emulate handleSubmit, trim, and reset semantics@lambdacurry/forms
TextField to a plain input and keep FormError inertAcceptance
bun run test:ci
.Compliance
Files modified
💻 View my work • 👤 Initiated by
Jake Ruesink
• About Codegen⛔ Remove Codegen from PR • 🚫 Ban action checks