-
Notifications
You must be signed in to change notification settings - Fork 197
Documentation Cleanup and Rustdoc Deployment Improvements #2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e8bd1f7
8617b85
f81d951
2774a22
e77a113
8bf5cdd
b977068
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,23 @@ | ||
//! # An implementation of the Cairo virtual machine | ||
//! # Cairo VM | ||
//! | ||
//! This crate provides a fast and safe implementation of the Cairo virtual machine in Rust. | ||
//! | ||
//! - [Project README](https://github.com/lambdaclass/cairo-vm/blob/main/README.md) | ||
//! - [Extended documentation](https://github.com/lambdaclass/cairo-vm/blob/main/docs/README.md) | ||
//! | ||
//! ## Features | ||
//! - STARK-friendly execution trace | ||
//! - Custom hint processor support | ||
//! - Tracing and debugging tools | ||
Comment on lines
+1
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While the links are correct, the rest might be a copy (or can be included) in the README. |
||
//! | ||
//! ## Example | ||
//! ```rust | ||
//! use cairo_vm::vm::vm_core::VirtualMachine; | ||
//! // ... usage example ... | ||
//! ``` | ||
Comment on lines
+13
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This example doesn't seem to be very useful IMO. |
||
//! | ||
//! ## Diagrams | ||
//! Mermaid diagrams are supported in rustdoc via the `aquamarine` dependency. | ||
Comment on lines
+19
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this mean? Why is this here? |
||
//! | ||
//! ## Feature Flags | ||
//! - `std`: Enables usage of the [`std`] standard library. Enabled by default. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing most of this section?