Skip to content

Conversation

JereSalo
Copy link
Contributor

@JereSalo JereSalo commented Oct 9, 2025

Motivation

Description

Closes #issue_number

@JereSalo JereSalo changed the title initial changes fix(l1): change gas price unit used in Legacy and EIP-2930 transactions Oct 9, 2025
@github-actions github-actions bot added the L1 Ethereum client label Oct 9, 2025
Copy link

github-actions bot commented Oct 9, 2025

Lines of code report

Total lines added: 1
Total lines removed: 1
Total lines changed: 2

Detailed view
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/common/types/transaction.rs | 2838  | +1   |
+-------------------------------------------+-------+------+
| ethrex/crates/vm/backends/levm/mod.rs     | 460   | -1   |
+-------------------------------------------+-------+------+

Copy link

github-actions bot commented Oct 9, 2025

Benchmark Results Comparison

Benchmark Results: Factorial

Command Mean [s] Min [s] Max [s] Relative
main_revm_Factorial 243.1 ± 0.6 242.4 244.4 1.00
main_levm_Factorial 286.4 ± 1.6 283.1 289.0 1.18 ± 0.01
pr_levm_Factorial 317.5 ± 98.6 284.8 598.1 1.31 ± 0.41
Detailed Results

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
main_revm_BubbleSort 4.764 ± 0.022 4.737 4.803 1.02 ± 0.01
main_levm_BubbleSort 4.705 ± 0.021 4.673 4.727 1.01 ± 0.01
pr_revm_BubbleSort 4.786 ± 0.016 4.767 4.815 1.03 ± 0.01
pr_levm_BubbleSort 4.667 ± 0.018 4.639 4.695 1.00

Benchmark Results: ERC20Approval

Command Mean [s] Min [s] Max [s] Relative
main_revm_ERC20Approval 1.546 ± 0.008 1.535 1.559 1.00
main_levm_ERC20Approval 1.664 ± 0.013 1.648 1.682 1.08 ± 0.01
pr_revm_ERC20Approval 1.560 ± 0.008 1.552 1.576 1.01 ± 0.01
pr_levm_ERC20Approval 1.654 ± 0.009 1.638 1.671 1.07 ± 0.01

Benchmark Results: ERC20Mint

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Mint 185.1 ± 0.7 184.2 186.6 1.00
main_levm_ERC20Mint 203.7 ± 15.0 196.1 246.0 1.10 ± 0.08
pr_revm_ERC20Mint 187.8 ± 0.8 186.7 188.7 1.01 ± 0.01
pr_levm_ERC20Mint 198.7 ± 1.7 196.4 201.3 1.07 ± 0.01

Benchmark Results: ERC20Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Transfer 355.4 ± 1.8 352.8 357.9 1.00
main_levm_ERC20Transfer 389.6 ± 3.9 385.4 396.3 1.10 ± 0.01
pr_revm_ERC20Transfer 357.3 ± 1.1 355.9 359.7 1.01 ± 0.01
pr_levm_ERC20Transfer 387.3 ± 2.7 383.3 391.1 1.09 ± 0.01

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Factorial 243.1 ± 0.6 242.4 244.4 1.00
main_levm_Factorial 286.4 ± 1.6 283.1 289.0 1.18 ± 0.01
pr_revm_Factorial 244.2 ± 1.2 243.1 247.0 1.00 ± 0.01
pr_levm_Factorial 317.5 ± 98.6 284.8 598.1 1.31 ± 0.41

Benchmark Results: FactorialRecursive

Command Mean [s] Min [s] Max [s] Relative
main_revm_FactorialRecursive 1.704 ± 0.097 1.431 1.755 1.00
main_levm_FactorialRecursive 8.671 ± 0.097 8.488 8.855 5.09 ± 0.30
pr_revm_FactorialRecursive 1.715 ± 0.034 1.667 1.762 1.01 ± 0.06
pr_levm_FactorialRecursive 8.693 ± 0.117 8.595 8.945 5.10 ± 0.30

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Fibonacci 218.0 ± 1.0 216.2 220.0 1.00
main_levm_Fibonacci 262.4 ± 3.7 257.5 270.3 1.20 ± 0.02
pr_revm_Fibonacci 218.8 ± 0.9 217.8 220.8 1.00 ± 0.01
pr_levm_Fibonacci 260.4 ± 1.2 258.1 261.7 1.19 ± 0.01

Benchmark Results: FibonacciRecursive

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_FibonacciRecursive 943.2 ± 24.3 924.0 1008.9 1.02 ± 0.03
main_levm_FibonacciRecursive 1039.9 ± 5.2 1034.3 1049.3 1.13 ± 0.02
pr_revm_FibonacciRecursive 920.3 ± 11.5 903.5 937.2 1.00
pr_levm_FibonacciRecursive 1047.2 ± 10.2 1035.8 1070.3 1.14 ± 0.02

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ManyHashes 12.4 ± 0.0 12.4 12.5 1.00
main_levm_ManyHashes 13.9 ± 0.1 13.7 14.1 1.11 ± 0.01
pr_revm_ManyHashes 12.5 ± 0.2 12.4 13.0 1.01 ± 0.01
pr_levm_ManyHashes 13.8 ± 0.2 13.7 14.2 1.11 ± 0.01

Benchmark Results: MstoreBench

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_MstoreBench 273.9 ± 0.9 272.8 275.7 1.00
main_levm_MstoreBench 754.3 ± 3.3 751.2 759.2 2.75 ± 0.02
pr_revm_MstoreBench 276.1 ± 2.5 273.6 281.4 1.01 ± 0.01
pr_levm_MstoreBench 755.1 ± 3.7 750.7 761.7 2.76 ± 0.02

Benchmark Results: Push

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Push 312.4 ± 0.8 311.4 313.6 1.00 ± 0.01
main_levm_Push 835.5 ± 2.9 832.0 842.5 2.68 ± 0.02
pr_revm_Push 312.2 ± 2.0 307.2 314.0 1.00
pr_levm_Push 838.1 ± 6.7 833.1 851.6 2.68 ± 0.03

Benchmark Results: SstoreBench_no_opt

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_SstoreBench_no_opt 223.5 ± 10.2 218.7 252.3 2.46 ± 0.12
main_levm_SstoreBench_no_opt 90.9 ± 1.4 88.3 92.3 1.00 ± 0.02
pr_revm_SstoreBench_no_opt 220.6 ± 1.8 218.8 225.2 2.43 ± 0.05
pr_levm_SstoreBench_no_opt 90.8 ± 1.5 88.5 92.5 1.00

Base automatically changed from support_blockchain_tests to main October 9, 2025 14:09
@JereSalo JereSalo changed the base branch from main to skipped_tests_reason October 9, 2025 14:48
@JereSalo JereSalo changed the title fix(l1): change gas price unit used in Legacy and EIP-2930 transactions fix(l1): use 256 bits for gas price in Legacy and EIP-2930 transactions Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant