Skip to content

refactor(l1,l2): separate binaries #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

refactor(l1,l2): separate binaries #4829

wants to merge 26 commits into from
+691 −566

Conversation

ManuelBilbao
Copy link
Contributor

Motivation

Description

Closes #issue_number

ilitteri and others added 21 commits October 7, 2025 16:26
@ilitteri
Start grouping l2 deps under an l2 feature flag
cd8736f
@fedacking
Added missing constant
1086d93
@fedacking
L1 compiles without sdk
df1697b
@fedacking
Fixed build dependency
1dea512
@fedacking
fixed linter
a157af1
@fedacking
separated build rs files
8e5d50c
@fedacking
Compiles l2
d60dfdc
@fedacking
Fixed defaults
17e1029
@fedacking
Update server.rs
0fd5a7a
@fedacking
Lint temporary change
8f5de90
@fedacking
made make test and lint work
ca3bf67 
- Separated make lint into lint-l1 and lint-l2 for it to cover both scenarios.
- Made it so that make tests runs with l2 (not necesary for the test itself, but the benches are a dev dependency and break without that feature flag)
@fedacking
Added sql to lint
343b368
@fedacking
minor fix
ef27d43
@fedacking
Clippy for expect
40864eb
@fedacking
Update sp1.rs
48498dc
@fedacking
Merge remote-tracking branch 'origin/main' into separate_binaries
d91e7e8
@fedacking
Update Cargo.toml
0f47a2f
@fedacking
simplified build.rs
a7dc856
@fedacking
Update Makefile
e1ccbaa
@ManuelBilbao
Merge branch 'main' into separate_binaries
7e33114
@ManuelBilbao
Merge branch 'main' into separate_binaries
c19180f
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2025 •
edited
Loading

Lines of code report

Total lines added: 423
Total lines removed: 364
Total lines changed: 787

Detailed view 
+-----------------------------------------------------------+-------+------+
| File                                                      | Lines | Diff |
+-----------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/build.rs                                | 31    | -364 |
+-----------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/build_l2.rs                             | 374   | +374 |
+-----------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/cli.rs                                  | 519   | +3   |
+-----------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/initializers.rs                         | 411   | +3   |
+-----------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/lib.rs                                  | 6     | +1   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/backend/sp1.rs                | 136   | +1   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/block_producer.rs              | 229   | +3   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_committer.rs                | 722   | +1   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/metrics.rs                   | 565   | +1   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/network.rs                   | 361   | +3   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/connection/handshake.rs | 508   | +2   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/connection/server.rs    | 871   | +9   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/error.rs                | 102   | +2   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/l2/l2_connection.rs     | 441   | +10  |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/message.rs              | 304   | +9   |
+-----------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/mod.rs                  | 11    | +1   |
+-----------------------------------------------------------+-------+------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ManuelBilbao @ilitteri @fedacking