-
Notifications
You must be signed in to change notification settings - Fork 108
chore(l1): memory enhancement - no transactional rocksdb + no cache #4839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Copilot <[email protected]>
This reverts commit 7c5315c.
Lines of code reportTotal lines added: Detailed view
|
Here is a table comparision of 2 runs of this PR vs main: Node Memory (RSS) & Host in images
This is an enhancement of ~40~50% in the Mean and ~30~40% in peaks, it appears to be a noticeable regression related to time ~50% slower, but we need more test to validate it wasn't an issue of the particular runs (variance for the runs is still high) |
…space to avoid unneded diff
Motivation
This PR reduce memory by 40~50%
Description
This PR sits on top of #4821 and after different testing scenarios we came up with this cut in memory:
The caveat is that it appears to be 50% slower, we need to double check it.