chore(l1): move WARN logs to DEBUG when a tx is not able to be added to the mempool
#4841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-o
changed the title
WARN logs to DEBUG when a tx is not able to be added to the mempool
rodrigo-o
commented
Oct 10, 2025
Comment on lines
807
to
825
| match e { | ||
| // Some of the more common mempool errors are logged at debug level, we might want to move all of them to debug in the future | ||
| ethrex_blockchain::error::MempoolError::NonceTooLow | ||
| | ethrex_blockchain::error::MempoolError::NotEnoughBalance | ||
| | ethrex_blockchain::error::MempoolError::UnderpricedReplacement => { | ||
| log_peer_debug( | ||
| &state.node, | ||
| &format!("Error adding transaction common: {e}"), | ||
| ); | ||
| continue; | ||
| } | ||
| _ => { | ||
| log_peer_warn( | ||
| &state.node, | ||
| &format!("Error adding transaction: {e}"), | ||
| ); | ||
| continue; | ||
| } | ||
| } |
There was a problem hiding this comment.
If we agree we can move them all to debug, otherwise this tackles 99% of all logs that are seen in the current sepolia and mainnet executions
PS: the errors aren't matched rn, Im looking into it
Lines of code reportTotal lines added: Detailed view |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses log spam by downgrading common mempool-related transaction errors from WARN to DEBUG level. The changes reduce noise in production logs when transactions fail to be added to the mempool for common, expected reasons.
- Move three specific mempool errors (
NonceTooLow,NotEnoughBalance,UnderpricedReplacement) from WARN to DEBUG logging - Add client name information to peer logging functions for better debugging context
- Implement
client_name()method to extract client information from node version strings
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/networking/p2p/types.rs | Adds client_name() method to extract client name from node version |
| crates/networking/p2p/rlpx/utils.rs | Updates logging functions to include client name in log format |
| crates/networking/p2p/rlpx/connection/server.rs | Changes specific mempool errors from WARN to DEBUG level logging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have some
WARNlogs spamming the node while on Sepolia or Mainnet, we want to remove them given taht they don't require attention.Description
This PR move the most common of these errors (the one that are spammed during most of mainnet executions) to debug:
Attempted to replace a pooled transaction with an underpriced transactionNonce for account too lowAccount does not have enough balance to cover the tx costWe could move them all to debug instead but wanted some feedback first. It also adds information to the peer logs related to the client. We checked that these logs doesn't come from the same source of clients, here is a summary of a node in mainnet running for a couple of hours
This is how a typical mainnet log looked like before:
We may want to further investigate if they are a constant influx of new transactions that we need to discard or if we are recieving the same transactions multiple times, for that I created #4842