Remove all-features in publish #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
=======================================
Coverage 70.17% 70.17%
=======================================
Files 165 165
Lines 32781 32781
=======================================
Hits 23003 23003
Misses 9778 9778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Oppen
reviewed
Sep 29, 2025
.github/workflows/publish.yml
Outdated
| run: cargo publish -p lambdaworks-gpu --token ${{ secrets.CARGO_REGISTRY_TOKEN }} | ||
| - name: Publish crate lambdaworks-math | ||
| run: cargo publish -p lambdaworks-math --token ${{ secrets.CARGO_REGISTRY_TOKEN }} --all-features | ||
| run: cargo publish -p lambdaworks-math --token ${{ secrets.CARGO_REGISTRY_TOKEN }} --features "parallel std alloc lambdaworks-serde-binary lambdaworks-serde-string proptest instruments" |
There was a problem hiding this comment.
instruments is MacOS specific, if it is what I think it is. So it won't work in the CI.
There was a problem hiding this comment.
Fix in 5bf83aa
Oppen
reviewed
Sep 29, 2025
.github/workflows/publish.yml
Outdated
| run: cargo publish -p lambdaworks-math --token ${{ secrets.CARGO_REGISTRY_TOKEN }} --features "parallel std alloc lambdaworks-serde-binary lambdaworks-serde-string proptest instruments" | ||
| - name: Publish crate lambdaworks-crypto | ||
| run: cargo publish -p lambdaworks-crypto --token ${{ secrets.CARGO_REGISTRY_TOKEN }} --all-features | ||
| run: cargo publish -p lambdaworks-crypto --token ${{ secrets.CARGO_REGISTRY_TOKEN }} --features "asm std serde test_fiat_shamir parallel alloc" |
There was a problem hiding this comment.
test_fiat_shamir is probably not needed.
There was a problem hiding this comment.
Fix in 5bf83aa
pablodeymo
approved these changes
Sep 29, 2025
Oppen
approved these changes
Sep 29, 2025
jotabulacios
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.