forked from 0xMiden/miden-client
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: create account from Package #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lima-limon-inc
wants to merge
13
commits into
next
Choose a base branch
from
fabrizioorsi-account-from-package
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ddb94ac
refactor: component_templates now also receive `.masp` files
lima-limon-inc f33a3cc
wip: error handling
lima-limon-inc c0426ae
refactor: add new packages flag to separate inputs
lima-limon-inc c4f6de0
chore: slight retouches to error handling
lima-limon-inc c62aad2
chore: linter errors
lima-limon-inc 2542f11
chore: add changelog entry
lima-limon-inc eb6884a
feat: check the file extension before passing the path
lima-limon-inc dd32f20
chore: update doc comment
lima-limon-inc 7c684f6
refactor: minor clean-up
lima-limon-inc 0047ce1
chore: clippy lints
lima-limon-inc b285982
typo: lease -> least
lima-limon-inc 9617791
feat: add packages flag to new-wallet command
lima-limon-inc 90c41b3
chore: clippy
lima-limon-inc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sidenote: I believe this list is not optional since at least one element has to be passed in, source: https://github.com/lambdaclass/miden-client/pull/25/files#diff-95eb60497fe9b9ad958ac1c26595181b35ee51f5e192ebe32ac9689cecb768c2L254-R360.AFAIK, this is only optional when building a wallet.