Add Support for PHP 8.5, Drop Support for PHP 8.1

[gsteel]

• Adds Support for PHP 8.5 in Composer
• Upgrades Psalm to latest, fixing or baselining where appropriate
• Psalm upgrade necessitates soft or hard final throughout, but a number of shipped classes have been baselined for this as they are likely extension points.

[Xerkus]

class must be final should be disabled for src imo.

    <issueHandlers>
        <ClassMustBeFinal>
            <errorLevel type="suppress">
                <directory name="src" />
            </errorLevel>
        </ClassMustBeFinal>
    </issueHandlers>

[gsteel]

class must be final should be disabled for src imo.

For this lib, perhaps, because it contains quite a few extension points - but even then, it forces us to explicitly state which shipped classes are fit for user inheritance. I'd argue that there are several non-final classes here that could/should be final.

Generally speaking, I prefer final by default and this issue helps with that…

[Ocramius]

So... how do we deal with the failures? They are, pretty much:

1) LaminasTest\Stdlib\StringWrapper\IntlTest::testStrlen with data set #0 ('ascii', 'abcdefghijklmnopqrstuvwxyz', 26)
Encoding ascii not supported

58) LaminasTest\Stdlib\StringWrapper\NativeTest::testStrPad with data set "negative-pad-length" ('utf-8', 'äääöö', -2, 'ö', 1, 'äääöö')
Encoding utf-8 not supported

1) /github/workspace/test/ArrayObjectTest.php:171
ArrayObject::exchangeArray(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants

[gsteel]

The only failure is Using an object as a backing array for ArrayObject is deprecated from a test context.

We have Laminas\ArrayObject::exchangeArray($whatever) where whatever can be any iterable, whereas PHP is now deprecating \ArrayObject::exchangeArray(iterable $a), so I haven't figured out whether I should just fix the test, or, also deprecate iterables to the Laminas equivalent and writes tests to cover the deprecation.

[gsteel]

For my reference: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_arrayobject_and_arrayiterator_with_objects

Obviously you already know about this @Ocramius considering you voted on it 😁

[gsteel]

I've deprecated passing non-array values to Laminas\ArrayObject::exchangeArray() to more closely match the deprecation in regular \ArrayObject.

Why does this re-implementation of ArrayObject even exist?

Also, rather than fixing the actual PHP deprecation in the test, I'm effecitively silencing it.

[Xerkus]

Why does this re-implementation of ArrayObject even exist?

IIRC it was needed to better mimic array behavior with nested values. This one returns by reference so the code below works:

$arrayObject['nested_array']['foo'] = 'bar';

Array access has many other quirks so we no longer use it anywhere. zend-config was the biggest consumer I think.

[Ocramius]

Obviously you already know about this @Ocramius considering you voted on it 😁

Yeah, it was more about what we do about it. I'm fine with deprecating our behavior 👍

[Ocramius]

🚢

[Ocramius]

Thanks @gsteel!