Skip to content

✨ Rename --force in delete to --confirm/--no-confirm #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

✨ Rename --force in delete to --confirm/--no-confirm #61

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
12b87ef
:sparkles: Add require-empty flag for deletion
Zethson Aug 14, 2024
702ff74
Merge branch 'main' into feature/require_empty
Zethson Aug 14, 2024
2637dff
add missing type
Zethson Aug 14, 2024
d326dc5
Merge branch 'main' of https://github.com/laminlabs/lamin-cli into fe…
Zethson Aug 16, 2024
9cad79e
:art: Confirm/no-confirm
Zethson Aug 16, 2024
caac815
:art: Merge
Zethson Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lamin_cli/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,13 @@ def close():
# fmt: off
@main.command()
@click.argument("instance", type=str, default=None)
@click.option("--force", is_flag=True, default=False, help="Do not ask for confirmation.") # noqa: E501
@click.option("--confirm/--no-confirm", default=True, help="Whether to ask for confirmation.") # noqa: E501
# fmt: on
def delete(instance: str, force: bool = False):
def delete(instance: str, confirm: bool = True):
"""Delete an instance."""
from lamindb_setup._delete import delete

return delete(instance, force=force)
return delete(instance, force=not confirm)


@main.command()
Expand Down