Skip to content

chore: port pre-create LANGFLOW_CONFIG_DIR #13212#13342

Merged
Adam-Aghili merged 2 commits into
release-1.9.4from
port-langflow-config-dir
May 26, 2026
Merged

chore: port pre-create LANGFLOW_CONFIG_DIR #13212#13342
Adam-Aghili merged 2 commits into
release-1.9.4from
port-langflow-config-dir

Conversation

@Adam-Aghili

@Adam-Aghili Adam-Aghili commented May 26, 2026

Copy link
Copy Markdown
Collaborator

backport of #13212

Summary by CodeRabbit

  • Chores
    • Enhanced Docker deployment configuration across all container images to ensure proper directory creation and file permission settings, allowing the application to reliably write and manage runtime files during startup without encountering permission-related errors.

Review Change Stack

@Adam-Aghili Adam-Aghili requested a review from erichare May 26, 2026 15:48
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c05cc71f-4766-452b-a276-2d742dcb65c8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Five Docker runtime images now pre-create the /app/langflow directory with non-root user (uid=1000) ownership and group-writable permissions. This ensures fresh Docker Compose named volumes at that path inherit correct permissions, allowing the container to write startup files without permission errors.

Changes

Docker non-root user volume initialization

Layer / File(s) Summary
Pre-create /app/langflow with non-root ownership across Dockerfile variants
docker/build_and_push.Dockerfile, docker/build_and_push_backend.Dockerfile, docker/build_and_push_base.Dockerfile, docker/build_and_push_ep.Dockerfile, docker/build_and_push_with_extras.Dockerfile
Five Dockerfile runtime stages add a RUN step that creates /app/langflow and sets owner:group to 1000:0 with group-writable permissions, ensuring non-root container user can write required runtime files when Docker Compose mounts fresh volumes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • langflow-ai/langflow#13212: Both PRs modify Docker runtime stages to pre-create /app/langflow with non-root uid=1000 ownership and permissions, ensuring fresh named volumes support startup file writes.

Suggested labels

bug, lgtm

Suggested reviewers

  • mendonk
  • vjgit96

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Test Coverage For New Implementations ❌ Error PR modifies 5 Docker files to pre-create /app/langflow directory but includes no specific tests validating this new Docker configuration change. Add tests to docker_test.yml workflow that verify /app/langflow exists and has correct ownership (uid 1000) and permissions (group-writable) in each Docker image.
Test Quality And Coverage ⚠️ Warning No tests added for Dockerfile changes. Existing Docker workflows only verify image builds and version, not the new directory pre-creation and permission fixes. Add tests validating /app/langflow directory exists with uid 1000:0, group-writable permissions (g+rwX), and correct volume mount behavior.
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change—porting the pre-create LANGFLOW_CONFIG_DIR change from PR #13212 to the current branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test File Naming And Structure ✅ Passed This PR contains only Docker configuration changes with no test files. The check is not applicable as it evaluates test file naming and structure, but no test files exist in this PR.
Excessive Mock Usage Warning ✅ Passed This PR contains only Docker build file modifications with no test files added or modified. The custom check for excessive mock usage is not applicable to this infrastructure-focused PR.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch port-langflow-config-dir

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@erichare erichare left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions Bot added lgtm This PR has been approved by a maintainer ignore-for-release and removed ignore-for-release labels May 26, 2026
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.26%. Comparing base (c34b79f) to head (ad75de9).
⚠️ Report is 20 commits behind head on release-1.9.4.

❌ Your project status has failed because the head coverage (50.08%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-1.9.4   #13342      +/-   ##
=================================================
+ Coverage          52.94%   53.26%   +0.31%     
=================================================
  Files               2030     2033       +3     
  Lines             184071   184843     +772     
  Branches           26210    28940    +2730     
=================================================
+ Hits               97464    98462     +998     
+ Misses             85492    85267     -225     
+ Partials            1115     1114       -1     
Flag Coverage Δ
backend 56.32% <ø> (+0.09%) ⬆️
frontend 53.31% <ø> (+0.44%) ⬆️
lfx 50.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 120 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 35%
35.47% (40695/114715) 68.12% (5605/8227) 35.95% (943/2623)

Unit Test Results

Tests Skipped Failures Errors Time
4018 0 💤 0 ❌ 0 🔥 7m 25s ⏱️

@Adam-Aghili Adam-Aghili merged commit 75b3cc9 into release-1.9.4 May 26, 2026
300 of 302 checks passed
@Adam-Aghili Adam-Aghili deleted the port-langflow-config-dir branch May 26, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants