Fehlalarm Verb/Adjektiv

[palakkhinvasara]

#12038 #12038
Fixes a false positive in VerbAgreementRule where adjective/verb ambiguous
tokens like "faul" were incorrectly detected as finite verbs.

Example:
"Während er faul auf der Couch saß, musste ich putzen."

The rule now ignores adjective readings when no real finite verb reading is
present.

Added regression coverage in VerbAgreementRuleTest.

Summary by CodeRabbit

• Bug Fixes

  • Improved German grammar checking to avoid incorrectly flagging adjective forms as finite verbs.
  • Reduced false-positive verb agreement warnings in sentences containing adjective readings.

• Tests

  • Added coverage for correct sentences involving verbs such as “saß,” “musste,” “ist,” and “bleibt.”

[coderabbitai]

Walkthrough

The German verb agreement rule now filters adjective-only token readings during finite-verb detection. Regression tests add three valid sentences involving ambiguous verb and adjective forms.

Changes

Verb agreement detection

Layer / File(s)	Summary
Finite-verb reading filter and regression coverage languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/VerbAgreementRule.java, languagetool-language-modules/de/src/test/java/org/languagetool/rules/de/VerbAgreementRuleTest.java	isFiniteVerb checks for qualifying person-specific verb readings that are not marked :SFT, rejects adjective-only readings, and adds three no-match regression assertions.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• languagetool-org/languagetool#12070: Updates the same finite-verb detection logic and German regression tests.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: reducing false alarms in verb/adjective handling.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[palakkhinvasara]

Hi @marcoagpinto @jaumeortola , Can you please review this PR?

Thanks,
palak

[marcoagpinto]

Heya,

Please ask Jaume: @jaumeortola

Jaume, could you please review?

Thanks!

[palakkhinvasara]

Hi @jaumeortola , Can you please review this PR?

Thanks,
palak

[palakkhinvasara]

Hi @marcoagpinto , Can you please review this PR?I have raised this since yesterday

Thanks,
palak