Hash token guard credentials during validation#59586
Closed
Nipun404 wants to merge 1 commit intolaravel:13.xfrom
Closed
Hash token guard credentials during validation#59586Nipun404 wants to merge 1 commit intolaravel:13.xfrom
Nipun404 wants to merge 1 commit intolaravel:13.xfrom
Conversation
Contributor
Author
|
Hey , @taylorotwell could you share the reasoning behind closing this? Would love to understand so I can improve the contribution. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TokenGuard::validatedoes not respect hashed token configuration (hash => true), leading to inconsistent behavior compared toTokenGuard::user.Currently:
user()→ hashes the incoming token before lookupvalidate()→ passes the raw token directlyFor applications storing API tokens as SHA-256 hashes, this can cause
validateto returnfalseeven when the provided plain token is valid.Solution
This change updates
TokenGuard::validateto hash the provided credential when the guard is configured withhash => true, aligning its behavior withTokenGuard::user.Benefit to Users
user()andvalidate()Backward Compatibility
This change does not introduce breaking behavior:
hash => false(default), behavior remains unchangedhash => true, where hashing is already expected and used inTokenGuard::userThis ensures existing applications relying on raw tokens continue to function as before.
Tests
validatehashes credentials whenhash => trueThese tests confirm:
TokenGuard::userhash => falseThe integration test ensures the complete authentication pipeline works correctly.
=>This pull request is a follow-up to a previously closed PR with the same change, updated to include a more detailed explanation and additional test coverage (including integration test).