Fix File::types() discarding prior chain configuration#59587
Closed
vashukarn wants to merge 1 commit intolaravel:13.xfrom
Closed
Fix File::types() discarding prior chain configuration#59587vashukarn wants to merge 1 commit intolaravel:13.xfrom
vashukarn wants to merge 1 commit intolaravel:13.xfrom
Conversation
When called as an instance method (e.g. File::image()->max(1)->types([...])), types() was a static factory that silently constructed a fresh instance, dropping any previously chained constraints. Route both static and instance calls through magic methods so chaining mutates the existing instance while preserving the documented File::types(...) factory entry point.
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #59242.
File::types()was a static factory returningnew static(), so calling it fluently afterimage()/max()(e.g.File::image()->max(1)->types(['jpg'])) silently dropped all prior constraints with no warning.This routes both static and instance calls to
types()through__call/__callStatic, delegating to a protectedapplyTypes()setter:File::types([...])— still works (BC preserved), now via__callStatic.File::image()->max(1)->types([...])— now mutates the existing instance instead of throwing away configuration.Macroable's magic methods are aliased so existing macro support is unaffected.@methodannotations are added so IDEs and static analysis still recognize both forms.Test plan
File::image()->max(1)->types(['jpg', 'jpeg'])correctly fails on an oversized image.max.File::types(['png'])static form still works.