Add support for secure email change with conflict resolution and verification flow #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leanup. - Introduced unverified_email support for Users wishing to change email - Added VerifyUserEmail job to handle safe transition and remove conflicts - Modified VerifyEmailController to use new logic during verification - Updated migration to include unverified_email column - Adjusted settings UI to support pending email change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for safe email changes by allowing users to set a
unverified_emailand confirming it through the standard email verification process.What's included:
unverified_emailfield added touserstableunverified_emailreservationsVerifyEmailControllerand a newVerifyUserEmailservice classVerifiedis dispatched after a successful commitWhy?
Previously, a user could set
emaildirectly, bypassing email verification and blocking others from using that address. This PR resolves the issue by decoupling pending email updates from the actual verifiedemailand confirming them via a secure flow.