refactor: use Appearance enum and centralize labels/icons #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

sagar-s-bhedodkar wants to merge 2 commits into laravel:main from sagar-s-bhedodkar:feature/theme-enum-refactor

+99 −77

sagar-s-bhedodkar commented Oct 21, 2025

What Changed

Converted the Appearance type from a string union to a TypeScript enum.
Centralized the theme labels and icons in use-appearance.tsx.
Updated AppearanceToggleTab to use the enum and centralized mappings.
Removed hardcoded strings in the toggle buttons.

Why

Makes theme management type-safe.
Reduces duplicate string literals.
Prepares the codebase for easier addition of new themes in the future.
Improves maintainability and readability.

sagar-s-bhedodkar added 2 commits

October 21, 2025 12:23


          refactor: use Appearance enum and centralize labels/icons

ce3c698


          fix: use APPEARANCE_KEY variable to satisfy ESLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet