Migrate to Vite #1598
Merged
Migrate to Vite #1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bit unsure about styleci. I'd expect it to commit style preferences, but it only reports them. Tried to fix them but its now reporting about an expected trailing comma at |
|
Thanks! |
crynobone
added a commit
that referenced
this pull request
Aug 13, 2025
The tag has been removed via #1598 Signed-off-by: Mior Muhammad Zaki <[email protected]>
taylorotwell
pushed a commit
that referenced
this pull request
Aug 13, 2025
The tag has been removed via #1598 Signed-off-by: Mior Muhammad Zaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from mix to Vite. I created a new PR as #1474 is open for already a year. Felt easier to start with a fresh slate and it allowed me to get a better feeling of the project structure.
I tried to mimic Horizon's project structure as much as possible. Copied the same stuff over like
.gitattributes,style.cietc. Also the way assets are handled are similar to Horizon, which is a remark in the other PR.If there is a preference to update the other PR instead, I can give that a try as well.