Fix concurrency issue in SocketServer and address deprecations#1185
Fix concurrency issue in SocketServer and address deprecations#1185ramkrishna-xyz wants to merge 1 commit intolavalink-devs:masterfrom
Conversation
Replaced mutableMapOf with ConcurrentHashMap for resumableSessions in SocketServer.kt to prevent concurrent modification exceptions during session resumption and cleanup. Also suppressed deprecation warnings in PlayerRestHandler.kt to clean up the build output while maintaining backward compatibility.
This comment was marked as spam.
This comment was marked as spam.
|
I feel like this was made with AI |
|
@pryzmian what made you think so |
|
do you have an actual instance of a |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
While we haven't seen an actual |
This comment was marked as spam.
This comment was marked as spam.
This comment has been minimized.
This comment has been minimized.
|
@ToddyTheNoobDud the message was indeed ai generated because my english is like very bad so we will be in a serious type discussion here so I used ai to enhance my pull request message |
This PR replaces
mutableMapOfwithConcurrentHashMapforresumableSessionsinSocketServer.kt. This preventsConcurrentModificationExceptionduring session resumption and cleanup. It also adds@Suppress("DEPRECATION")toPlayerRestHandlerto reduce build noise.