Skip to content

feat: add Meshery UI integration test for mui-datatables#49

Merged
leecalcote merged 1 commit intolayer5io:masterfrom
Rajesh-Nagarajan-11:master
Apr 21, 2026
Merged

feat: add Meshery UI integration test for mui-datatables#49
leecalcote merged 1 commit intolayer5io:masterfrom
Rajesh-Nagarajan-11:master

Conversation

@Rajesh-Nagarajan-11
Copy link
Copy Markdown
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 commented Apr 18, 2026

Notes for Reviewers

Adds a GitHub Actions workflow to test mui-datatables changes against Meshery UI on every PR

  • Builds mui-datatables from the PR

  • Installs it into Meshery UI

  • Builds and tests Meshery UI with the change

Implemented the same workflow that we have in sistent

✅ Tested with Forked Repo sample workflow link

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
Copy link
Copy Markdown

@kishore08-07 kishore08-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rajesh-Nagarajan-11 , LGTM.

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!

@KhushamBansal
Copy link
Copy Markdown
Member

LGTM!!

@Junnygram
Copy link
Copy Markdown

LGTM

1 similar comment
@Sbragul26
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown

@banana-three-join banana-three-join left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too familiar with Github CI but from what I read and taking into account the fact that it's the same CI used in Sistent just being implemented in Meshery UI, I would say it's good to go!

@YASHMAHAKAL
Copy link
Copy Markdown
Contributor

Not too familiar with Github CI but from what I read and taking into account the fact that it's the same CI used in Sistent just being implemented in Meshery UI, I would say it's good to go!

@banana-three-join mui-datatables is a React component library that gives you a fully-featured, production-ready data table out of the box, built on top of Material UI (MUI).
Instead of building a complex table from scratch every time you need to display data (with sorting, searching, filtering, pagination, etc.), you just install this library and pass it your data. It handles everything for you.

This workflow automatically builds your mui-datatables PR into a local package (L28-L47) downloads the real Meshery UI repository, and installs your new table package into it. (L60-L62, run: npm install ../../mui-datatables/${{ env.MUI_DATATABLES_PACKAGE }})
It then commands Meshery to build and test itself, proving with 100% certainty that your PR changes do not break the downstream Meshery application.

Copy link
Copy Markdown

@Oluwatunmise-olat Oluwatunmise-olat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leecalcote
Copy link
Copy Markdown
Member

Not too familiar with Github CI but from what I read and taking into account the fact that it's the same CI used in Sistent just being implemented in Meshery UI, I would say it's good to go!

@banana-three-join mui-datatables is a React component library that gives you a fully-featured, production-ready data table out of the box, built on top of Material UI (MUI). Instead of building a complex table from scratch every time you need to display data (with sorting, searching, filtering, pagination, etc.), you just install this library and pass it your data. It handles everything for you.

This workflow automatically builds your mui-datatables PR into a local package (L28-L47) downloads the real Meshery UI repository, and installs your new table package into it. (L60-L62, run: npm install ../../mui-datatables/${{ env.MUI_DATATABLES_PACKAGE }}) It then commands Meshery to build and test itself, proving with 100% certainty that your PR changes do not break the downstream Meshery application.

Is this documented somewhere?

@YASHMAHAKAL
Copy link
Copy Markdown
Contributor

YASHMAHAKAL commented Apr 20, 2026

Not too familiar with Github CI but from what I read and taking into account the fact that it's the same CI used in Sistent just being implemented in Meshery UI, I would say it's good to go!

@banana-three-join mui-datatables is a React component library that gives you a fully-featured, production-ready data table out of the box, built on top of Material UI (MUI). Instead of building a complex table from scratch every time you need to display data (with sorting, searching, filtering, pagination, etc.), you just install this library and pass it your data. It handles everything for you.

This workflow automatically builds your mui-datatables PR into a local package (L28-L47) downloads the real Meshery UI repository, and installs your new table package into it. (L60-L62, run: npm install ../../mui-datatables/${{ env.MUI_DATATABLES_PACKAGE }}) It then commands Meshery to build and test itself, proving with 100% certainty that your PR changes do not break the downstream Meshery application.

Is this documented somewhere?

@leecalcote No, this is what I learnt when i firstly got introduced with this repository 🙂
However the README.md documents the first paragraph

@leecalcote leecalcote merged commit cd2c3e8 into layer5io:master Apr 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.