feat: add Meshery UI integration test for mui-datatables#49
feat: add Meshery UI integration test for mui-datatables#49leecalcote merged 1 commit intolayer5io:masterfrom
Conversation
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
kishore08-07
left a comment
There was a problem hiding this comment.
Thanks @Rajesh-Nagarajan-11 , LGTM.
|
LGTM!! |
|
LGTM |
1 similar comment
|
LGTM |
banana-three-join
left a comment
There was a problem hiding this comment.
Not too familiar with Github CI but from what I read and taking into account the fact that it's the same CI used in Sistent just being implemented in Meshery UI, I would say it's good to go!
@banana-three-join mui-datatables is a React component library that gives you a fully-featured, production-ready data table out of the box, built on top of Material UI (MUI). This workflow automatically builds your mui-datatables PR into a local package (L28-L47) downloads the real Meshery UI repository, and installs your new table package into it. (L60-L62, run: npm install ../../mui-datatables/${{ env.MUI_DATATABLES_PACKAGE }}) |
Is this documented somewhere? |
@leecalcote No, this is what I learnt when i firstly got introduced with this repository 🙂 |
Notes for Reviewers
Adds a GitHub Actions workflow to test mui-datatables changes against Meshery UI on every PR
Builds mui-datatables from the PR
Installs it into Meshery UI
Builds and tests Meshery UI with the change
Implemented the same workflow that we have in sistent
✅ Tested with Forked Repo sample workflow link
Signed commits