Conversation
c3ce8dd to
12a57fa
Compare
There was a problem hiding this comment.
Pull request overview
This PR advances the plugin refactor by introducing a declarative “wiring” model on PluginSpec, a serializer that materializes wiring into _plugins answers, and initial template/test scaffolding to render backend routing via plugin entries.
Changes:
- Add wiring dataclasses (
PluginWiring,RouterWiring, etc.) toPluginSpecand populate wiring for in-tree services. - Introduce
plugin_composerto serialize plugin specs into_pluginsanswers withwhen-predicate filtering. - Extend
routing.py.jinjato render router imports/mounts from plugin wiring and add tests for wiring/serialization and routing render parity.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
tests/core/test_plugin_wiring.py |
Adds unit tests for wiring dataclass defaults, serializer behavior, and in-tree wiring counts/gating. |
tests/core/test_plugin_render_parity.py |
Adds byte-for-byte render parity test for routing.py.jinja (legacy flags vs plugin wiring). |
aegis/templates/copier-aegis-project/{{ project_slug }}/app/components/backend/api/routing.py.jinja |
Adds plugin-driven import/mount loops and tweaks legacy imports to align with wiring output. |
aegis/core/services.py |
Populates wiring for in-tree services (auth/ai/comms/insights/payment). |
aegis/core/plugin_spec.py |
Introduces wiring dataclasses and adds wiring: PluginWiring to PluginSpec. |
aegis/core/plugin_composer.py |
New serializer to produce _plugins answer entries and evaluate when predicates. |
aegis/core/manual_updater.py |
Aliases _plugins to plugins in the render context for manual updates. |
aegis/commands/plugins.py |
Docstring text adjustment (inspection surface wording). |
12a57fa to
f75b29e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.