Conversation
There was a problem hiding this comment.
Pull request overview
Adds end-to-end CLI + ManualUpdater support for installing/removing external plugins, including reverse-dependency checks and test fixtures to validate plugin template distribution and answers-file updates.
Changes:
- Introduces
aegis add <plugin>/aegis remove <plugin>dispatch paths backed byManualUpdater.add_plugin()/ManualUpdater.remove_plugin(). - Adds
reverse_dependents()inaegis.core.plugin_compatplus unit tests to validate reverse-dependency detection. - Adds an in-repo fake plugin fixture (
tests/fixtures/aegis_plugin_test) and expands ManualUpdater plugin tests for add/remove round-trips.
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
aegis/commands/add.py |
Adds plugin resolution + install flow and dispatch to add-service for services. |
aegis/commands/remove.py |
Adds plugin resolution + uninstall flow and reverse-dependency checks before removal. |
aegis/core/manual_updater.py |
Implements add_plugin() and remove_plugin() orchestration around answers updates, shared regen, template install/cleanup, and post-gen tasks. |
aegis/core/plugin_compat.py |
Adds _plugins parsing improvements and new reverse_dependents() helper. |
aegis/i18n/locales/en.py |
Adds English strings for plugin add/remove prompts/status messages. |
tests/core/test_manual_updater_plugins.py |
Adds end-to-end add/remove plugin round-trip tests and idempotency coverage. |
tests/core/test_plugin_compat.py |
Adds unit tests for reverse_dependents() across services/plugins/components deps. |
tests/fixtures/aegis_plugin_test/... (all added files) |
Fake plugin distribution fixture (spec + templates + packaging metadata) used by tests. |
212b8e6 to
695d61c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.