adjust excerpt function to make suffix a keyword argument#105
Open
jeremybmerrill wants to merge 4 commits intoleapfrogtechnology:mainfrom
Open
adjust excerpt function to make suffix a keyword argument#105jeremybmerrill wants to merge 4 commits intoleapfrogtechnology:mainfrom
jeremybmerrill wants to merge 4 commits intoleapfrogtechnology:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would extend the existing
excerptfunction to take an optional keyword argumentsuffix=that would be appended to the end of the excerpt, instead of the current...ellipsis. If the argument is unspecified, the...suffix will be retained, i.e. this change is backwards compatible.For instance, if
suffixis set to an empty string, the excerpt will be just the first N characters of the string. ``{{excerpt string 10 suffix=""}}returns'That can o'` and `{{excerpt string 10 suffix="asdf"}}` returns `'That can oasdf'`.I have added tests; all pre-existing tests pass unmodified.
For context: just-handlebars-helpers is packaged with Apache Superset's handlebars charts. I need to do some string processing there and want to use excerpt without the ellipsis.
Notes:
sprintfimplementation.suffixis an optional positional argument, you can revert the last commit in this PR.