Fix migration image content directory setting#502
Merged
Conversation
Use the nested CONTENT__DIR environment variable in the migration image so deploy-time curriculum validation can find the copied YAML content after flat settings compatibility was removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTENT__DIRenvironment variable.CONTENT_DIRtoCONTENT__DIR.Why
The production deploy failed during the migration image self-check because the image still exported the old flat
CONTENT_DIRname after the flat settings compatibility layer was removed.Validation
cd api && uv run ruff check . ../packages/learn-to-cloud-sharedcd api && uv run ruff format --check . ../packages/learn-to-cloud-sharedcd api && uv run ty check --exclude scripts --exclude tests .cd packages/learn-to-cloud-shared && uv run ty check --exclude tests .cd api && uv run pytest tests/cd packages/learn-to-cloud-shared && uv run pytest tests/cd apps/verification-functions && uv run ruff check . && uv run ruff format --check . && uv run ty check . && uv run python -c "import function_app"Note: Docker is not installed in the current environment, so I could not run the exact container smoke test locally.