hugo/feature/Add CountTheRightNumber gameplay#1941
Open
Conversation
Contributor
HPezz
commented
Jul 4, 2025
- ✨ (NewGEK): Add CountTheRightNumber choice model
- ✨ (NewGEK): Add CountTheRightNumber model
- ✨ (NewGEK): Add CountTheRightNumber gameplay
- ✨ (NewGEK): Add TTS x CountTheRightNumber coordinator
- ✨ (NewGEK x NewCK): Add TTS x CountTheRightNumber to Example
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the “CountTheRightNumber” exercise type end-to-end, including data models, gameplay logic, TTS coordinator, and example integration.
- Defined
CoordinatorCountTheRightNumberModeland its choice model - Implemented
NewGameplayCountTheRightNumberlogic andTTSCoordinatorCountTheRightNumberUI coordinator - Integrated the new exercise into the main coordinator, enum, and example YAML
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Modules/ContentKit/Sources/GameEngine/_NewSystem/Models/CoordinatorModels/CoordinatorCountTheRightNumberModel.swift | New payload model and JSON decoding |
| Modules/ContentKit/Sources/GameEngine/_NewSystem/Models/ChoiceModels/CoordinatorCountTheRightNumberChoiceModel.swift | New choice model for count-the-right-number |
| Modules/ContentKit/Sources/GameEngine/_NewSystem/Interfaces/TTS/Coordinators/TTSCoordinator+CountTheRightNumber.swift | TTS gameplay coordinator and SwiftUI views |
| Modules/ContentKit/Sources/GameEngine/_NewSystem/Gameplays/NewGameplayCountTheRightNumber.swift | Core gameplay logic for counting selections |
| Modules/ContentKit/Sources/GameEngine/_NewSystem/Coordinators/CurrentExerciseCoordinator.swift | Hooked up .countTheRightNumber in exercise flow |
| Modules/ContentKit/Sources/Content/_NewSystem/Exercise/NewExercise+Gameplay.swift | Added countTheRightNumber enum case |
| Modules/ContentKit/Examples/ContentKitExample/Resources/new_gek_activity_tts.yml | Example payloads for the new gameplay |
Comments suppressed due to low confidence (1)
Modules/ContentKit/Sources/GameEngine/_NewSystem/Models/ChoiceModels/CoordinatorCountTheRightNumberChoiceModel.swift:22
- The struct is declared public but its properties are internal. Consider marking
value,type,expected, andchoiceIDsas public so external users can access them as intended.
let value: String
...ces/GameEngine/_NewSystem/Models/CoordinatorModels/CoordinatorCountTheRightNumberModel.swift
Show resolved
Hide resolved
Modules/ContentKit/Sources/GameEngine/_NewSystem/Gameplays/NewGameplayCountTheRightNumber.swift
Outdated
Show resolved
Hide resolved
...s/GameEngine/_NewSystem/Interfaces/TTS/Coordinators/TTSCoordinator+CountTheRightNumber.swift
Outdated
Show resolved
Hide resolved
...s/GameEngine/_NewSystem/Interfaces/TTS/Coordinators/TTSCoordinator+CountTheRightNumber.swift
Show resolved
Hide resolved
c66fc09 to
41a19b1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


