Skip to content

Comments

hugo/feature/Add CountTheRightNumber gameplay#1941

Open
HPezz wants to merge 5 commits intodevelopfrom
hugo/feature/Add-CountTheRightNumber-gameplay
Open

hugo/feature/Add CountTheRightNumber gameplay#1941
HPezz wants to merge 5 commits intodevelopfrom
hugo/feature/Add-CountTheRightNumber-gameplay

Conversation

@HPezz
Copy link
Contributor

@HPezz HPezz commented Jul 4, 2025

  • ✨ (NewGEK): Add CountTheRightNumber choice model
  • ✨ (NewGEK): Add CountTheRightNumber model
  • ✨ (NewGEK): Add CountTheRightNumber gameplay
  • ✨ (NewGEK): Add TTS x CountTheRightNumber coordinator
  • ✨ (NewGEK x NewCK): Add TTS x CountTheRightNumber to Example

@HPezz HPezz requested a review from Copilot July 4, 2025 12:46
@HPezz HPezz self-assigned this Jul 4, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the “CountTheRightNumber” exercise type end-to-end, including data models, gameplay logic, TTS coordinator, and example integration.

  • Defined CoordinatorCountTheRightNumberModel and its choice model
  • Implemented NewGameplayCountTheRightNumber logic and TTSCoordinatorCountTheRightNumber UI coordinator
  • Integrated the new exercise into the main coordinator, enum, and example YAML

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Modules/ContentKit/Sources/GameEngine/_NewSystem/Models/CoordinatorModels/CoordinatorCountTheRightNumberModel.swift New payload model and JSON decoding
Modules/ContentKit/Sources/GameEngine/_NewSystem/Models/ChoiceModels/CoordinatorCountTheRightNumberChoiceModel.swift New choice model for count-the-right-number
Modules/ContentKit/Sources/GameEngine/_NewSystem/Interfaces/TTS/Coordinators/TTSCoordinator+CountTheRightNumber.swift TTS gameplay coordinator and SwiftUI views
Modules/ContentKit/Sources/GameEngine/_NewSystem/Gameplays/NewGameplayCountTheRightNumber.swift Core gameplay logic for counting selections
Modules/ContentKit/Sources/GameEngine/_NewSystem/Coordinators/CurrentExerciseCoordinator.swift Hooked up .countTheRightNumber in exercise flow
Modules/ContentKit/Sources/Content/_NewSystem/Exercise/NewExercise+Gameplay.swift Added countTheRightNumber enum case
Modules/ContentKit/Examples/ContentKitExample/Resources/new_gek_activity_tts.yml Example payloads for the new gameplay
Comments suppressed due to low confidence (1)

Modules/ContentKit/Sources/GameEngine/_NewSystem/Models/ChoiceModels/CoordinatorCountTheRightNumberChoiceModel.swift:22

  • The struct is declared public but its properties are internal. Consider marking value, type, expected, and choiceIDs as public so external users can access them as intended.
    let value: String

@HPezz HPezz force-pushed the hugo/feature/Add-CountTheRightNumber-gameplay branch from c66fc09 to 41a19b1 Compare July 4, 2025 13:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant