Draft
Conversation
Contributor
HPezz
commented
Dec 22, 2023
HPezz
commented
- 🧑💻 (RobotKit): Extend UIColor with toHsv() function
- ♻️ (RobotKit): Update Robot.Color to future Gradient struct
- ✨ (RobotKit): Add Robot.Gradient struct
- 🐛 (GEK): Add reinforcer duration
- ♻️ (GEK): Refactor Pairing breathe animation with Gradient
HPezz
force-pushed
the
hugo/feature/Add-Gradient-class
branch
2 times, most recently
from
2e6c295 to
908d583
Compare
HPezz
force-pushed
the
hugo/feature/Add-Gradient-class
branch
from
908d583 to
450a2c8
Compare
|
ladislas
reviewed
Jan 11, 2024
Member
ladislas
left a comment
ladislas
left a comment
There was a problem hiding this comment.
LGTM 👍 quelques questions techniques :)
Comment on lines
+48
to
+64
| public var robotUiColor: UIColor { | ||
| UIColor( | ||
| red: Double(self.robotRGB[0]) / 255.0, | ||
| green: Double(self.robotRGB[1]) / 255.0, | ||
| blue: Double(self.robotRGB[2]) / 255.0, | ||
| alpha: 1.0 | ||
| ) | ||
| } | ||
|
|
||
| public var screenUiColor: UIColor { | ||
| UIColor( | ||
| red: Double(self.screenRGB[0]) / 255.0, | ||
| green: Double(self.screenRGB[1]) / 255.0, | ||
| blue: Double(self.screenRGB[2]) / 255.0, | ||
| alpha: 1.0 | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
pourquoi tu as besoin de passer par UIColor? pourquoi pas une simple struct?
Comment on lines
+21
to
+46
| public func color(at position: Float) -> Robot.Color { | ||
| let positionClamped = max(min(position, 1), 0) | ||
|
|
||
| let scaledIndex = positionClamped * Float(self.gradientColors.count - 1) | ||
| let firstIndex = Int(scaledIndex) | ||
| let secondIndex = min(firstIndex + 1, gradientColors.count - 1) | ||
| let fraction = CGFloat(scaledIndex - Float(firstIndex)) | ||
|
|
||
| let firstColor = self.gradientColors[firstIndex] | ||
| let secondColor = self.gradientColors[secondIndex] | ||
|
|
||
| let (h1, s1, v1) = firstColor.robotUiColor.toHSV() | ||
| let (h2, s2, v2) = secondColor.robotUiColor.toHSV() | ||
|
|
||
| let h = self.interpolateHue(from: h1, to: h2, fraction: fraction) | ||
| let s = self.interpolate(from: s1, to: s2, fraction: fraction) | ||
| let v = self.interpolate(from: v1, to: v2, fraction: fraction) | ||
|
|
||
| let uiColor = UIColor(hue: h, saturation: s, brightness: v, alpha: 1) | ||
|
|
||
| let r = UInt8(max(min(uiColor.cgColor.components![0] * 255.0, 255), 0)) | ||
| let g = UInt8(max(min(uiColor.cgColor.components![1] * 255.0, 255), 0)) | ||
| let b = UInt8(max(min(uiColor.cgColor.components![2] * 255.0, 255), 0)) | ||
|
|
||
| return Robot.Color(red: r, green: g, blue: b) | ||
| } |
Member
There was a problem hiding this comment.
par curiosité, cette formule elle vient d'où? c'est intéressant de mettre en commentaire la source de l'explication scientifique/mathématiques du calcul
Comment on lines
+15
to
+17
| public init(fromColors colors: Color...) { | ||
| self.gradientColors = colors | ||
| } |
Member
There was a problem hiding this comment.
j'ai un "petit" soucis avec ça : c'est que si tu mets + de 2 couleurs, tu pars du principe qu'elles sont toutes équidistante les unes des autres.
dans Illustrator, tu peux faire varier la distance entre 2 couleurs.
dans notre cas ça peut être très pratique pour "accélérer/raccourcir" les zones dans lesquelles les variations sont faibles (ou faiblement perçues) et "ralentir/allonger" des zones où la variation est plus importante
Member
There was a problem hiding this comment.
une manière simple est d'avoir un autre init qui te permet d'associer couleur et position
Comment on lines
+48
to
+64
| public var robotUiColor: UIColor { | ||
| UIColor( | ||
| red: Double(self.robotRGB[0]) / 255.0, | ||
| green: Double(self.robotRGB[1]) / 255.0, | ||
| blue: Double(self.robotRGB[2]) / 255.0, | ||
| alpha: 1.0 | ||
| ) | ||
| } | ||
|
|
||
| public var screenUiColor: UIColor { | ||
| UIColor( | ||
| red: Double(self.screenRGB[0]) / 255.0, | ||
| green: Double(self.screenRGB[1]) / 255.0, | ||
| blue: Double(self.screenRGB[2]) / 255.0, | ||
| alpha: 1.0 | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| public var robotUiColor: UIColor { | |
| UIColor( | |
| red: Double(self.robotRGB[0]) / 255.0, | |
| green: Double(self.robotRGB[1]) / 255.0, | |
| blue: Double(self.robotRGB[2]) / 255.0, | |
| alpha: 1.0 | |
| ) | |
| } | |
| public var screenUiColor: UIColor { | |
| UIColor( | |
| red: Double(self.screenRGB[0]) / 255.0, | |
| green: Double(self.screenRGB[1]) / 255.0, | |
| blue: Double(self.screenRGB[2]) / 255.0, | |
| alpha: 1.0 | |
| ) | |
| } | |
| public var robotUIColor: UIColor { | |
| UIColor( | |
| red: Double(self.robotRGB[0]) / 255.0, | |
| green: Double(self.robotRGB[1]) / 255.0, | |
| blue: Double(self.robotRGB[2]) / 255.0, | |
| alpha: 1.0 | |
| ) | |
| } | |
| public var screenUIColor: UIColor { | |
| UIColor( | |
| red: Double(self.screenRGB[0]) / 255.0, | |
| green: Double(self.screenRGB[1]) / 255.0, | |
| blue: Double(self.screenRGB[2]) / 255.0, | |
| alpha: 1.0 | |
| ) | |
| } |
ladislas
force-pushed
the
main
branch
2 times, most recently
from
1d4a80e to
a25305d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.