fix: Duplicate results-processing loop removed from search_items(#1631)#1633
Open
Aditi-Singh-14 wants to merge 5 commits into
Open
fix: Duplicate results-processing loop removed from search_items(#1631)#1633Aditi-Singh-14 wants to merge 5 commits into
Aditi-Singh-14 wants to merge 5 commits into
Conversation
🎉 Welcome to Hybrid Recommender, @Aditi-Singh-14!Thank you for your first pull request! Here's what happens next:
⏱️ Please respond to any review comments within 48 hours. 📖 Resources: Happy contributing! 🚀 |
|
🎉 Welcome to Hybrid Recommender, @Aditi-Singh-14! This is your first contribution here! Labels added: PR Description Checklist: What happens next:
⏱️ Please respond to review comments within 48 hours. |
1691650 to
9d6baed
Compare
Author
|
hi @leonagoel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull-Request
Why
Fixed an issue in the
search_itemslogic where a duplicate results-processing loop was silently overriding output data and dropping keys.Related issue linked
issue: #1631
What changed
search_itemsoutput.datasets/books.csvfile to the local workspace environment.Status
fix/search-items-loop