fix: add missing faiss-cpu dependency to requirements.txt #1665
Open
Pratyush-Panda-2006 wants to merge 1 commit into
Open
fix: add missing faiss-cpu dependency to requirements.txt #1665Pratyush-Panda-2006 wants to merge 1 commit into
Pratyush-Panda-2006 wants to merge 1 commit into
Conversation
|
🎉 Welcome to Hybrid Recommender, @Pratyush-Panda-2006! This is your first contribution here! Labels added: PR Description Checklist: What happens next:
⏱️ Please respond to review comments within 48 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1663
What Was Done
Created New Branch: Checked out the main branch, pulled the latest changes, and created a new branch fix/issue-1663.
Added Missing Dependency: Added faiss-cpu>=1.7.4 to
requirements.txt
to resolve the missing dependency for two_tower_retrieval.py and test_neural_retrieval.py.
Verified Functionality:
Installed faiss-cpu in the local environment and ran the tests.
Verified that tests/test_neural_retrieval.py now runs and passes successfully:
bash
pytest tests/test_neural_retrieval.py