Skip to content

More information in "outside reactive tracking context" warning #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

More information in "outside reactive tracking context" warning #3831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions reactive_graph/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ tracing = { version = "0.1.41", optional = true }
guardian = "1.2"
async-lock = "3.4.0"
send_wrapper = { version = "0.6.0", features = ["futures"] }
wasm_backtrace = "0.1.1"

[target.'cfg(all(target_arch = "wasm32", target_os = "unknown"))'.dependencies]
web-sys = { version = "0.3.72", features = ["console"] }
Expand Down
4 changes: 3 additions & 1 deletion reactive_graph/src/traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ impl<T: Source + ToAnySource + DefinedAt> Track for T {
use crate::diagnostics::SpecialNonReactiveZone;

if !SpecialNonReactiveZone::is_inside() {
let backtrace = wasm_backtrace::backtrace();
let called_at = Location::caller();
let ty = std::any::type_name::<T>();
let defined_at = self
Expand All @@ -143,7 +144,8 @@ impl<T: Source + ToAnySource + DefinedAt> Track for T {
let y = x.get() * 2\n ✅ YES let y = move || \
x.get() * 2.\n\n3. If you’re *trying* to access the \
value without tracking, use `.get_untracked()` or \
`.with_untracked()` instead."
`.with_untracked()` instead.\n\nComplete backtrace \
of the call site:\n{backtrace}"
));
}
}
Expand Down