bump pkimetal to v1.41.0 and ignore new ctlint warning#8713
Merged
aarongable merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
Updates the integration-test pkimetal sidecar from v1.20.0 to v1.41.0. Newer ctlint emits a warning for every certificate issued by an issuer that isn't in CCADB, which fires for all of our test certificates; ignore it in both zlint configs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mcpherrinm
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the pkimetal sidecar used in integration tests and adjusts zlint configuration to ignore a newly introduced ctlint warning that is expected for the repo’s non-CCADB test issuers.
Changes:
- Bump
ghcr.io/pkimetal/pkimetalfromv1.20.0tov1.41.0indocker-compose.yml. - Add an ignore rule for the new ctlint SCT-signature verification warning in both
test/configandtest/config-nextzlint TOML configs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker-compose.yml | Updates pkimetal container image tag to v1.41.0 for test runs. |
| test/config/zlint.toml | Ignores the new ctlint CCADB-dependent warning for test issuers. |
| test/config-next/zlint.toml | Mirrors the same ctlint ignore in the “next” test config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aarongable
approved these changes
Apr 14, 2026
jsha
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the integration-test pkimetal sidecar from v1.20.0 to v1.41.0.
The upgraded ctlint throws a new warning, "Cannot verify SCT signature without issuer SPKI, which could not be found in the available CCADB data", because our test PKI is of course not in its CCADB data, so ignore it.