Claude/add crafting instructions skill iysl b

[oaustegard]

As per https://bsky.app/profile/austegard.com/post/3macx7p5ynk2w and subsequent request for a PR

Recommendations

For skill-creator:

1. Rename to creating-skills
2. Rewrite frontmatter description with imperative verbs + "Use for:" triggers
3. Convert descriptive body text to imperative instructions
4. Delete all three scripts - they solve problems Claude can trivially solve (mkdir, zip, basic YAML validation)
5. Remove "About Skills" educational content or move to a reference

For skill-learning-patterns:

1. Rename to contributing-skills
2. Rewrite frontmatter description with imperative verbs + "Use for:" triggers
3. Delete the "When to Use This Skill" section (lines 24-33) - it's useless after activation
4. Move "When NOT to Contribute" content from recognizing-learnings.md into SKILL.md - this is core, not optional
5. Move "Specific vs General" content from validation-criteria.md into SKILL.md - this is core validation criteria
6. Condense pr-workflow.md significantly (416 lines for git branching workflow is excessive)
7. Keep contribution-examples.md as reference (truly optional examples)

[Copilot]

Pull request overview

This PR implements recommendations from a Bluesky discussion to restructure and improve the skill creation and contribution patterns. The changes focus on making skill documentation more actionable by converting descriptive content to imperative instructions and removing unnecessary helper scripts.

Key changes:

• Renamed skill-creator to creating-skills and skill-learning-patterns to contributing-skills (using gerund form)
• Deleted three Python utility scripts (init_skill.py, package_skill.py, quick_validate.py) as they solve trivial problems
• Moved core validation and contribution guidelines from optional references into main SKILL.md files
• Added comprehensive crafting-instructions skill with detailed guidance for Projects, Skills, and prompts
• Updated all frontmatter descriptions to use imperative verbs and explicit "Use for:" trigger patterns

Reviewed changes

Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
development/patterns/skill-creator/scripts/*.py	Removed three helper scripts that Claude can replace with simple commands
development/patterns/creating-skills/SKILL.md	Renamed from skill-creator, updated to use imperative language and gerund naming
development/patterns/creating-skills/LICENSE.txt	Added Apache 2.0 license file
development/patterns/contributing-skills/SKILL.md	Renamed from skill-learning-patterns, integrated "When NOT to Contribute" content
development/patterns/contributing-skills/references/*.md	Added comprehensive reference docs for validation, PR workflow, examples, and learning recognition
.claude/skills/crafting-instructions/*	New skill providing guidance for creating Claude instructions across three formats
README.md	Updated skill names and descriptions to reflect renames
CLAUDE.md	Added new file documenting the crafting-instructions skill

Comments suppressed due to low confidence (4)

development/patterns/creating-skills/SKILL.md:44

• The updated frontmatter description still uses third-person phrasing "Claude activates" rather than imperative action verbs. According to the PR description and the new guidance in this very file, descriptions should "Lead with imperative action verbs" and end with "Use for:" triggers. The description should be rewritten to start with imperative verbs like other parts of this PR demonstrate (e.g., "Create and package skills..." instead of "The name and description... determine when Claude activates...").
  development/patterns/creating-skills/SKILL.md:187
• Inconsistency in naming convention guidance. Line 187 states to use "gerund form (e.g., creating-skills, not skill-creator)", but the actual skill name in the frontmatter is "creating-skills" which is indeed a gerund. However, the guidance should clarify that this applies to the skill name field specifically, since the directory name would match. Consider rephrasing for clarity: "Name uses gerund form: lowercase, hyphens only" to avoid confusion about what "Name" refers to (both the frontmatter field and directory name).
  development/patterns/creating-skills/SKILL.md:40
• The "About Skills" section (lines 11-40) contains educational content about what skills are and how they work. According to the PR description recommendations, this educational content should be "deleted or moved to a reference" since it's not imperative instructions. This section is descriptive ("Skills are...", "A skill is structured...") rather than imperative ("Create skills...", "Structure skills..."). Consider moving this to a reference file or rewriting in imperative form.
  development/patterns/creating-skills/SKILL.md:4
• The Apache License 2.0 is being added as a new file (202 lines). However, the frontmatter in SKILL.md line 4 references "LICENSE.txt" with the text "Complete terms in LICENSE.txt". This suggests the license should contain actual license terms, but the file being added is the full Apache 2.0 license text. This appears correct - "Complete terms" likely means "the complete license terms are in LICENSE.txt". However, this phrasing could be clearer. Consider whether the frontmatter should say "Apache-2.0" or link to the file more explicitly.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cpfiffer]

@letta-code can you take a look

[github-actions]

Letta Code encountered an error —— View job

Failed with exit code 128

---

The agent encountered an issue before updating the comment.

[cpfiffer]

@letta-code please try again

[github-actions]

Letta Code encountered an error —— View job

Failed with exit code 128

---

The agent encountered an issue before updating the comment.

[cpfiffer]

@letta-code you can do it buddy

[github-actions]

Letta Code encountered an error —— View job

Failed with exit code 128

---

The agent encountered an issue before updating the comment.

[cpfiffer]

Review: Skill Creator & Learning Patterns Improvements

🔴 Critical Issue: Wrong Directory Path

The PR modifies files at development/patterns/skill-creator/ and development/patterns/skill-learning-patterns/ - but these paths no longer exist.

The repository was restructured in December 2025. These skills are now at:

• meta/skill-creator/ (not development/patterns/skill-creator/)
• meta/skill-learning/ (not development/patterns/skill-learning-patterns/)

The PR branch appears to be based on an old version of main before the restructuring. Current main doesn't have development/patterns/ at all.

Required fix: Rebase on current main and apply changes to the correct paths in meta/.

---

✅ What's Good (if applied to correct paths)

Naming improvements:

• skill-creator → creating-skills (follows gerund naming convention)
• skill-learning-patterns → contributing-skills (more descriptive, gerund form)

Description improvements:

• Uses imperative verbs ("Create and package...", "Recognize learnings...")
• Adds explicit "Use for:" triggers
• More actionable and discoverable

Script deletion rationale is sound:

• init_skill.py (303 lines) - mkdir -p is trivial
• package_skill.py (110 lines) - zip -r is trivial
• quick_validate.py (65 lines) - PR review handles validation

Content quality:

• Contributing-skills SKILL.md is comprehensive with excellent pitfall documentation
• Creating-skills SKILL.md has clear step-by-step process
• Good examples throughout

---

📝 Recommendation

Request changes - The core improvements are valuable but the PR needs to be rebased and retargeted:

1. Rebase on current main
2. Apply changes to meta/skill-creator/ → rename to meta/creating-skills/
3. Apply changes to meta/skill-learning/ → rename to meta/contributing-skills/
4. Update README.md references (if needed)

The content quality is good - it just needs to target the right files.

---

🤖 Reviewed by Keeper (agent-627d9a86-630f-462c-98c1-4929c6d3d941)