Fix timecode add_us() drifting on sub-frame times#23
Merged
Conversation
lexag
added a commit
that referenced
this pull request
Jan 23, 2026
* bump version to 2.1.0 * Change Beat Debug implementation to derive (#12) * remove custom Debug formatting for Beat * derive Debug instead * Add SmallMessage::CueData for uC support (#13) * add SmallMessage::CueData and SmallCueData * fix clippy error * Update rust.yml to support 'dev' branch (#15) * Additions to Message (#14) * separate TimecodeState from TransportState * add LargeMessage::Log and LogItem * Add options to edit metronome click sound settings (#18) * init metronome config * integrate metronome config * add SystemConfigurationChange::ChangeMetronome * QOL conversion functions for StaticString (#16) * implement str from &[u8] * StaticString from_int(i32) * add str::append, str::insert_replace * add str::from_float * add str::from_large_int * add str::insert_shift and str::replace * fix broken doclink * Fix root cause of #17 Monitor crash due to udp serialization (#19) * separate serde impl depending on postcard or json for mem::str * fill out serde_json test * Add us_to_next_beat to BeatState (#20) * Add LTC state to CombinedStatus (#21) * Move TimecodeState from CombinedStatus to AudioSourceState * Fix timecode add_us drifting on sub-frame times (#23) * Remove debug std-imports
lexag
added a commit
that referenced
this pull request
Apr 12, 2026
* bump version to 2.1.0 * Change Beat Debug implementation to derive (#12) * remove custom Debug formatting for Beat * derive Debug instead * Add SmallMessage::CueData for uC support (#13) * add SmallMessage::CueData and SmallCueData * fix clippy error * Update rust.yml to support 'dev' branch (#15) * Additions to Message (#14) * separate TimecodeState from TransportState * add LargeMessage::Log and LogItem * Add options to edit metronome click sound settings (#18) * init metronome config * integrate metronome config * add SystemConfigurationChange::ChangeMetronome * QOL conversion functions for StaticString (#16) * implement str from &[u8] * StaticString from_int(i32) * add str::append, str::insert_replace * add str::from_float * add str::from_large_int * add str::insert_shift and str::replace * fix broken doclink * Fix root cause of #17 Monitor crash due to udp serialization (#19) * separate serde impl depending on postcard or json for mem::str * fill out serde_json test * Add us_to_next_beat to BeatState (#20) * Add LTC state to CombinedStatus (#21) * Move TimecodeState from CombinedStatus to AudioSourceState * Fix timecode add_us drifting on sub-frame times (#23) * Remove debug std-imports * Add SmallMessage::PlaybackData and LargeMessage::PlaybackHandlerChanged (#34) * add SmallMessage::PlaybackStatus * add LargeMessage::PlaybackHandlerChanged * fix clippy errors * fix clippy errors * Add Beat length and count override markers for editing (#33) * add override events * clarify event usage on count override * fix clippy errors * Add TimecodeProperties for LTC customizability and settings (#32) * add timecode properties * add properties to timecode event * fix clippy errors * Add Request::RunEvent (#37) * QoL functions for EventTable (#38) * add shifting events * add iterator functions * bump version to 2.2.0 * Cue recalculation functions respect override markers (#39) * cue respects beat count override * cue respects beat length override * Move RunEvent from Request to ControlAction, where it fits better * Serde default tags (#40) * add default tags to event properties * add default tag to show and cue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.