fix: add namedConstraintValue to tolerate identifiers in integer subtypes#15
Open
Jellyfrog wants to merge 1 commit intolextudio:mainfrom
Open
fix: add namedConstraintValue to tolerate identifiers in integer subtypes#15Jellyfrog wants to merge 1 commit intolextudio:mainfrom
Jellyfrog wants to merge 1 commit intolextudio:mainfrom
Conversation
…ypes MIB files that use named constants in subtype constraints (e.g. SYNTAX Unsigned32 (WAN7 | WAN8) in ARRIS-D5-SLOT-EXT-MIB) would fail with "Bad grammar near token type UPPERCASE_IDENTIFIER" errors. This adds a new relaxed grammar option that allows UPPERCASE_IDENTIFIER and LOWERCASE_IDENTIFIER in the value rule used for integer subtype constraints. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
|
Author
|
Few examples from https://github.com/librenms/librenms/tree/master/mibs |
lextm
added
priority:low
|
Unless there is a compelling example with significant impact on user base, this pull request is not going to be accepted. Problematic MIB documents should be fixed by their vendors. |
Author
|
These are the current ones from librenms mibs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MIB files that use named constants in subtype constraints (e.g. SYNTAX Unsigned32 (WAN7 | WAN8) in ARRIS-D5-SLOT-EXT-MIB) would fail with "Bad grammar near token type UPPERCASE_IDENTIFIER" errors.
This adds a new relaxed grammar option that allows UPPERCASE_IDENTIFIER and LOWERCASE_IDENTIFIER in the value rule used for integer subtype constraints.