Repository navigation
feat: prompt before launching mobile agent profiles - #803
Merged
Merged
Conversation
Open a prompt dialog from New Tab for opted-in Agent Profiles, matching desktop skip-or-prompt launch.
Contributor
There was a problem hiding this comment.
Important
Dictated prompts never enable Start Agent, so Skip is the only remaining launch control and it drops the text.
Reviewed changes
Mobile New Tab now collects a starting prompt before agentProfile.launch, matching desktop #731.
- Launch sheet — New dialog with Skip, Start Agent, dictation, and capability-gated attachments that insert host paths into the prompt.
- New Tab wiring — Profile menu actions carry the full
AgentProfileSummaryand open the sheet instead of launching immediately; a successful launch still selects the new tab. - Tests — Widget coverage for skip, start, close, in-dialog errors, image path insertion, and the New Tab prompt round-trip.
Grok | 𝕏
Listen on the prompt controller so dictation and other programmatic writes enable Start Agent.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
The launch sheet now listens on the prompt controller so dictated and other programmatic writes enable Start Agent.
- Controller listener —
_promptController.addListenerupdates_hasPromptand drives_canStart, matchingTerminalComposeBarand replacing theonChangedrebuild. - Coverage — Widget test assigns
controller.valuethe same way dictation does and asserts Start Agent becomes enabled, then launches the dictated text.
Grok | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Mobile New Tab now opens a prompt dialog before spawning an opted-in Agent Profile, matching desktop #731.
showInNewTabMenustill gates the menu. Profiles that are not opted in are not launched.No protocol version bump.
agentProfile.launchalready acceptsprompt, andagentProfilePromptLaunchV1is already inMOBILE_HELLO_CAPABILITIES.Validation
flutter analyzeon the touched mobile files (no issues)flutter test test/agent_profile_launch_sheet_test.dart test/workspace_tabs_screen_test.dart test/workspace_agent_comments_test.dartRisks
AGENTS.md was not updated: this is UI-only on a verb the runtime already allowlists.